Attention is currently required from: David Ruth, Eric Lai, Nick Vaccaro, Subrata Banik.
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79794?usp=email )
Change subject: mb/google/byra/var/*: Set WLAN device type back to pci
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
With this change incorporated, I only see _SB.PCI0.MCHC, and not _SB.PCI0.RP[..].MCHC devices. […]
the problem that prompted this change was that the RP04.MCHC device was being added to the LPI constraint list under the PEP device. I don't have access to a brya device currently to recheck, but if there's no bogus MCHC device getting added to the constraint list (which will cause Windows to BSOD, because there's an entry in the list which doesn't have a corresponding device in the dsdt/ssdt) then I'm good with the fix
--
To view, visit
https://review.coreboot.org/c/coreboot/+/79794?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: If5dad9deb040c8cb0c507e11726f0ba44ccb2909
Gerrit-Change-Number: 79794
Gerrit-PatchSet: 1
Gerrit-Owner: David Ruth
druth@chromium.org
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Attention: Eric Lai
ericllai@google.com
Gerrit-Attention: David Ruth
druth@chromium.org
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Comment-Date: Mon, 08 Jan 2024 15:43:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: David Ruth
druth@chromium.org
Comment-In-Reply-To: Matt DeVillier
matt.devillier@gmail.com
Gerrit-MessageType: comment