Attention is currently required from: Lance Zhao, Martin Roth, Frans Hendriks, Patrick Rudolph, Wim Vervoorn.
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49476 )
Change subject: ACPI: Separate device_nvs_t
......................................................................
Patch Set 10:
(1 comment)
File src/acpi/gnvs.c:
https://review.coreboot.org/c/coreboot/+/49476/comment/b475b779_898c137c
PS10, Line 79: gnvs + GNVS_DEVICE_NVS_OFFSET
nit: acpi_get_device_nvs()
Right, I'll change this in followups if we decide to keep the fixed offset at all.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/49476
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I878746b1f0f9152a27dc58e373d58115e2dff22c
Gerrit-Change-Number: 49476
Gerrit-PatchSet: 10
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Lance Zhao
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Wim Vervoorn
wvervoorn@eltan.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Lance Zhao
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Frans Hendriks
fhendriks@eltan.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Attention: Wim Vervoorn
wvervoorn@eltan.com
Gerrit-Comment-Date: Tue, 26 Jan 2021 22:24:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment