Attention is currently required from: Intel coreboot Reviewers, Patrick Rudolph, Riku Viitanen.
Angel Pons has posted comments on this change by Riku Viitanen. ( https://review.coreboot.org/c/coreboot/+/85793?usp=email )
Change subject: nb/sandybridge: Implement adjustable DRAM voltages
......................................................................
Patch Set 11:
(1 comment)
File src/northbridge/intel/sandybridge/raminit_native.c:
https://review.coreboot.org/c/coreboot/+/85793/comment/ac8d4b26_88a6d136?usp... :
PS11, Line 705: dram_jedecreset(ctrl);
Isn't this not reached on fast_boot though? I think we have to set it in fast boot flow too, because […]
I know Haswell does a JEDEC reset on the fast boot path too. I don't recall what Sandy Bridge does.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85793?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I1a8857deee85fd635429afd3cbf93cad7a7d589b
Gerrit-Change-Number: 85793
Gerrit-PatchSet: 11
Gerrit-Owner: Riku Viitanen
riku.viitanen@protonmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Intel coreboot Reviewers
intel_coreboot_reviewers@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Riku Viitanen
riku.viitanen@protonmail.com
Gerrit-Attention: Intel coreboot Reviewers
intel_coreboot_reviewers@intel.com
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Comment-Date: Thu, 16 Jan 2025 10:10:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Riku Viitanen
riku.viitanen@protonmail.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com