Change in coreboot[master]: superio/smsc/mec1308/acpi: Convert superio.asl to ASL 2.0 syntax

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45990 )

Change subject: superio/smsc/mec1308/acpi: Convert superio.asl to ASL 2.0 syntax
......................................................................

superio/smsc/mec1308/acpi: Convert superio.asl to ASL 2.0 syntax

Change-Id: I7d15dbb90bbf910cdfd59d67fa4d9ca41420b8d9
Signed-off-by: Elyes HAOUAS 
---
M src/superio/smsc/mec1308/acpi/superio.asl
1 file changed, 10 insertions(+), 10 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/90/45990/1

diff --git a/src/superio/smsc/mec1308/acpi/superio.asl b/src/superio/smsc/mec1308/acpi/superio.asl
index b688697..f692323 100644
--- a/src/superio/smsc/mec1308/acpi/superio.asl
+++ b/src/superio/smsc/mec1308/acpi/superio.asl
@@ -37,30 +37,30 @@

Method (ENTR, 0, NotSerialized)
    {
-		Store (0x55, SI2E)
+		SI2E = 0x55
    }

Method (EXIT, 0, NotSerialized)
    {
-		Store (0xaa, SI2E)
+		SI2E = 0xaa
    }

/* Parse activate register for an LDN */
    Method (ISEN, 1, NotSerialized)
    {
    	ENTR ()
-		Store (Arg0, SLDN)
-		Store (SACT, Local0)
+		SLDN = Arg0
+		Local0 = SACT
    	EXIT ()

/* Check if it exists */
-		If (LEqual (Local0, 0xFF))
+		If (Local0 == 0xFF)
    	{
    		Return (0x00)
    	}

/* Check if activated */
-		If (LEqual (Local0, One))
+		If (Local0 == 1)
    	{
    		Return (0x0F)
    	}
@@ -74,8 +74,8 @@
    Method (SENA, 1, NotSerialized)
    {
    	ENTR ()
-		Store (Arg0, SLDN)
-		Store (One, SACT)
+		SLDN = Arg0
+		SACT = 1
    	EXIT ()
    }

@@ -83,8 +83,8 @@
    Method (SDIS, 1, NotSerialized)
    {
    	ENTR ()
-		Store (Arg0, SLDN)
-		Store (Zero, SACT)
+		SLDN = Arg0
+		SACT = 0
    	EXIT ()
    }

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45990 )

Change subject: superio/smsc/mec1308/acpi: Convert superio.asl to ASL 2.0 syntax
......................................................................

Patch Set 1:

Any verification done?

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45990 )

Change subject: superio/smsc/mec1308/acpi: Convert superio.asl to ASL 2.0 syntax
......................................................................

Patch Set 1: Code-Review+2

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/45990 )

Change subject: superio/smsc/mec1308/acpi: Convert superio.asl to ASL 2.0 syntax
......................................................................

superio/smsc/mec1308/acpi: Convert superio.asl to ASL 2.0 syntax

Change-Id: I7d15dbb90bbf910cdfd59d67fa4d9ca41420b8d9
Signed-off-by: Elyes HAOUAS 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/45990
Tested-by: build bot (Jenkins) 
Reviewed-by: Angel Pons 
---
M src/superio/smsc/mec1308/acpi/superio.asl
1 file changed, 10 insertions(+), 10 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Angel Pons: Looks good to me, approved

diff --git a/src/superio/smsc/mec1308/acpi/superio.asl b/src/superio/smsc/mec1308/acpi/superio.asl
index b688697..f692323 100644
--- a/src/superio/smsc/mec1308/acpi/superio.asl
+++ b/src/superio/smsc/mec1308/acpi/superio.asl
@@ -37,30 +37,30 @@

Method (ENTR, 0, NotSerialized)
    {
-		Store (0x55, SI2E)
+		SI2E = 0x55
    }

Method (EXIT, 0, NotSerialized)
    {
-		Store (0xaa, SI2E)
+		SI2E = 0xaa
    }

/* Parse activate register for an LDN */
    Method (ISEN, 1, NotSerialized)
    {
    	ENTR ()
-		Store (Arg0, SLDN)
-		Store (SACT, Local0)
+		SLDN = Arg0
+		Local0 = SACT
    	EXIT ()

/* Check if it exists */
-		If (LEqual (Local0, 0xFF))
+		If (Local0 == 0xFF)
    	{
    		Return (0x00)
    	}

/* Check if activated */
-		If (LEqual (Local0, One))
+		If (Local0 == 1)
    	{
    		Return (0x0F)
    	}
@@ -74,8 +74,8 @@
    Method (SENA, 1, NotSerialized)
    {
    	ENTR ()
-		Store (Arg0, SLDN)
-		Store (One, SACT)
+		SLDN = Arg0
+		SACT = 1
    	EXIT ()
    }

@@ -83,8 +83,8 @@
    Method (SDIS, 1, NotSerialized)
    {
    	ENTR ()
-		Store (Arg0, SLDN)
-		Store (Zero, SACT)
+		SLDN = Arg0
+		SACT = 0
    	EXIT ()
    }