Attention is currently required from: Jérémy Compostella, Naresh Solanki.
Angel Pons has posted comments on this change by Naresh Solanki. ( https://review.coreboot.org/c/coreboot/+/85640?usp=email )
Change subject: soc/amd/glinda/cpu: Update cache info
......................................................................
Patch Set 3:
(1 comment)
File src/soc/amd/glinda/cpu.c:
https://review.coreboot.org/c/coreboot/+/85640/comment/d907b37d_3c0293b6?usp... :
PS3, Line 66: memcpy(info, &info_list[0], sizeof(*info));
This part may need some optimisation. The caller expect data for as part of struct info. […]
Oh, wait. This is only copying one element of the array.
```suggestion
*info = info_list[0];
```
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85640?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I46947e8ac62c903036a81642e03201e353c3dac6
Gerrit-Change-Number: 85640
Gerrit-PatchSet: 3
Gerrit-Owner: Naresh Solanki
naresh.solanki@9elements.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-CC: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Attention: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Attention: Naresh Solanki
naresh.solanki@9elements.com
Gerrit-Comment-Date: Wed, 15 Jan 2025 10:42:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Naresh Solanki
naresh.solanki@9elements.com