Attention is currently required from: Michał Żygowski, Tim Wawrzynczak. Michał Kopeć has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63467 )
Change subject: soc/intel/alderlake: add GPIO definitions for PCH-S ......................................................................
Patch Set 4:
(10 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/63467/comment/aeaf4907_9b0da013 PS3, Line 13: - Intel PCH-S EDS Vol1 (#621483)
This DOC ID is actually vol2
Done
File src/soc/intel/alderlake/gpio_pch_s.c:
https://review.coreboot.org/c/coreboot/+/63467/comment/ef296b7f_dad9b124 PS3, Line 70: INTEL_GPP_BASE(GPP_SPI0_IO_2, GPP_C0, GPP_C23, 288), /* GPP_C */
Let's add VPIO3 for completeness […]
Done
https://review.coreboot.org/c/coreboot/+/63467/comment/e04089a2_3e2972cb PS3, Line 72:
Missing community3 vw entries: […]
Done
https://review.coreboot.org/c/coreboot/+/63467/comment/70e0c97e_faa8452a PS3, Line 88: INTEL_GPP(GPP_D0, GPP_JTAG_TDO, GPP_CPU_TRSTB), /* JTAG */
Let's add CPU groups for completeness […]
Done
https://review.coreboot.org/c/coreboot/+/63467/comment/9850ba0a_cfac381d PS3, Line 173: .name = "GPP_SPI0AC",
Just GPP_AC
Done
https://review.coreboot.org/c/coreboot/+/63467/comment/791dcbdc_6522925a PS3, Line 204: [COMM_5] = { /* GPP D, JTAG */
GPP_D, JTAG, CPU
Done
File src/soc/intel/alderlake/include/soc/gpio_defs_pch_s.h:
https://review.coreboot.org/c/coreboot/+/63467/comment/7611c94a_0224c4ca PS3, Line 323: #define HOSTSW_OWN_REG_0 0x200
This is 0x150
Done
https://review.coreboot.org/c/coreboot/+/63467/comment/8e647902_b86a1d9c PS3, Line 324: #define GPI_INT_STS_0 0x220
This is 0x200
Done
https://review.coreboot.org/c/coreboot/+/63467/comment/0c605868_5de44ee7 PS3, Line 325: #define GPI_INT_EN_0 0x110
This is 0x220
Done
File src/soc/intel/alderlake/include/soc/gpio_soc_defs_pch_s.h:
https://review.coreboot.org/c/coreboot/+/63467/comment/96b734a2_ff58e945 PS3, Line 62: #define GPP_GSPI0_CLK_LOOPBK INC(GPP_I17) : #define GPP_GSPI1_CLK_LOOPBK INC(GPP_I18)
#define GPP_GSPI0_CLK_LOOPBK INC(GPP_I22) […]
Derp. Fixed
-
Michał Kopeć (Code Review)