Attention is currently required from: Hung-Te Lin, Paul Menzel. Rex-BC Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60317 )
Change subject: soc/mediatek/mt8186: Add devapc basic drivers ......................................................................
Patch Set 6:
(4 comments)
File src/soc/mediatek/mt8186/devapc.c:
https://review.coreboot.org/c/coreboot/+/60317/comment/8ed42308_e45df282 PS5, Line 6: static const struct apc_infra_peri_dom_8 infra_ao_sys0_devices[] = {
How did you create this? Copied from datasheet?
add information at the beginning of this file.
https://review.coreboot.org/c/coreboot/+/60317/comment/cf3fde74_b444199c PS5, Line 1252: int
unsigned int
Done
https://review.coreboot.org/c/coreboot/+/60317/comment/5012af72_21434786 PS5, Line 1306: int
unsigned int
Done
File src/soc/mediatek/mt8186/include/soc/devapc.h:
https://review.coreboot.org/c/coreboot/+/60317/comment/160b16cc_1eabbe0b PS5, Line 17: AO_APC_CON = 0x0F00,
Please add the datasheet name, revision and section, where you got the offsets from.
add information at the beginning of this file.
-
Rex-BC Chen (Code Review)