Hello Chris Wang,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/34842
to review the following change.
Change subject: [TEST-ONLY] change flashmap size for agesa debug build. ......................................................................
[TEST-ONLY] change flashmap size for agesa debug build.
increse COREBOOT size which from reduced from RO_UNUSED
BUG=none TEST=build careena coreboot image successfully with agesa debug enabling.
Signed-off-by: Chris Wang chris.wang@amd.corp-partner.google.com Change-Id: Ib44338af183d404d1e422cefa484d83aca9e1a19 --- M src/mainboard/google/kahlee/variants/baseboard/chromeos.fmd 1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/42/34842/1
diff --git a/src/mainboard/google/kahlee/variants/baseboard/chromeos.fmd b/src/mainboard/google/kahlee/variants/baseboard/chromeos.fmd index b746545..f48e8e4 100644 --- a/src/mainboard/google/kahlee/variants/baseboard/chromeos.fmd +++ b/src/mainboard/google/kahlee/variants/baseboard/chromeos.fmd @@ -28,13 +28,13 @@
WP_RO@0xC00000 0x400000 { RO_VPD(PRESERVE)@0x0 0x4000 - RO_UNUSED@0x4000 0x17B000 - RO_SECTION@0x17F000 0x281000 { + RO_UNUSED@0x4000 0x170000 + RO_SECTION@0x174000 0x28C000 { FMAP@0x0 0x800 RO_FRID@0x800 0x40 RO_FRID_PAD@0x840 0x7c0 GBB@0x1000 0x70000 - COREBOOT(CBFS)@0x71000 0x210000 + COREBOOT(CBFS)@0x71000 0x21B000 } } }
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34842 )
Change subject: [TEST-ONLY] change flashmap size for agesa debug build. ......................................................................
Patch Set 1:
(1 comment)
Can this change be abandoned?
https://review.coreboot.org/c/coreboot/+/34842/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/34842/1//COMMIT_MSG@7 PS1, Line 7: [TEST-ONLY] change flashmap size for agesa debug build. Please remove the dot/period at the end of the git commit message summary.
chris wang has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/34842 )
Change subject: [TEST-ONLY] change flashmap size for agesa debug build. ......................................................................
Abandoned
chris wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34842 )
Change subject: [TEST-ONLY] change flashmap size for agesa debug build. ......................................................................
Patch Set 1:
Patch Set 1:
(1 comment)
Can this change be abandoned?
sure.