Attention is currently required from: Nico Huber, Stefan Reinauer, David Hendricks, Paul Menzel, Angel Pons, ron minnich, Felix Held.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51825 )
Change subject: Documentation/contributing/coding_style: remove bug-causing rule
......................................................................
Patch Set 1:
(1 comment)
File Documentation/contributing/coding_style.md:
https://review.coreboot.org/c/coreboot/+/51825/comment/0b68684c_3fed1219
PS1, Line 196: ```
In misra-c (which was the target for coding resilience in coreboot before all these bad linux kernel […]
I mean, MISRA also mandates that all loop counters must be unsigned, all unsigned literals must be written with an explicit 'U' suffix, all truth checks must contain an explicit comparison operator, absolutely every single part of an expression needs its own parentheses, etc. (besides declaring a lot of things illegal that are essential for firmware development). MISRA is full on insanity and code written to comply with it is horribly unreadable from all the redundant boilerplate and extra characters sprinkled around everywhere. I would not consider it something to aspire to.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/51825
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I06422d4f6ce448766e50c7684bbeaa55ae825899
Gerrit-Change-Number: 51825
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Stefan Reinauer
reinauer@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ron minnich
rminnich@gmail.com
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Stefan Reinauer
reinauer@chromium.org
Gerrit-Attention: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: David Hendricks
david.hendricks@gmail.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: ron minnich
rminnich@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Thu, 15 Apr 2021 23:43:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Stefan Reinauer
stefan.reinauer@coreboot.org
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment