Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41815 )
Change subject: console: Update for vboot before bootblock ......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41815/6/src/console/init.c File src/console/init.c:
https://review.coreboot.org/c/coreboot/+/41815/6/src/console/init.c@70 PS6, Line 70: CONFIG(EARLY_PCI_BRIDGE)
I think you missed one negation there? It was stated elsewhere PCI config does not work inside psp-v […]
No negation missed. I just concluded from the cluttered condition that somebody wants to select both EARLY_PCI_BRIDGE and VBOOT_STARTS_BEFORE_BOOTBLOCK. Otherwise, this condition wouldn't need to be touched.
If they are incompatible, what we should do instead is make EARLY_PCI_BRIDGE depend on !VBOOT_STARTS_BEFORE_BOOTBLOCK. Just skipping the bridge init doesn't seem reasonable, what would the verstage be supposed to do with an initialized console behind an uninitialized bridge? Run into timeouts the whole day?