View Change
1 comment:
File src/console/init.c:
Patch Set #6, Line 70: CONFIG(EARLY_PCI_BRIDGE)
I think you missed one negation there? It was stated elsewhere PCI config does not work inside psp-v […]
No negation missed. I just concluded from the cluttered condition
that somebody wants to select both EARLY_PCI_BRIDGE and
VBOOT_STARTS_BEFORE_BOOTBLOCK. Otherwise, this condition
wouldn't need to be touched.
If they are incompatible, what we should do instead is make
EARLY_PCI_BRIDGE depend on !VBOOT_STARTS_BEFORE_BOOTBLOCK.
Just skipping the bridge init doesn't seem reasonable, what
would the verstage be supposed to do with an initialized
console behind an uninitialized bridge? Run into timeouts the
whole day?
To view, visit change 41815. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifc9fb0810e0816fe0a68e52287eda6145043a619
Gerrit-Change-Number: 41815
Gerrit-PatchSet: 6
Gerrit-Owner: Martin Roth <martinroth@google.com>
Gerrit-Reviewer: Aaron Durbin <adurbin@chromium.org>
Gerrit-Reviewer: Eric Peers <epeers@google.com>
Gerrit-Reviewer: Furquan Shaikh <furquan@google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: Raul Rangel <rrangel@chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Kyösti Mälkki <kyosti.malkki@gmail.com>
Gerrit-CC: Nico Huber <nico.h@gmx.de>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Comment-Date: Tue, 09 Jun 2020 22:55:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber <nico.h@gmx.de>
Comment-In-Reply-To: Kyösti Mälkki <kyosti.malkki@gmail.com>
Gerrit-MessageType: comment