Attention is currently required from: Elyes Haouas, Jakub Czapiga, Julius Werner, Martin L Roth, Maximilian Brune, Nico Huber.
Felix Singer has posted comments on this change by Elyes Haouas. ( https://review.coreboot.org/c/coreboot/+/83459?usp=email )
Change subject: stddef.h: Introduce nullptr constant
......................................................................
Patch Set 26:
(1 comment)
File src/include/stddef.h:
https://review.coreboot.org/c/coreboot/+/83459/comment/36d09bed_dbfbcf51?usp... :
PS26, Line 25: #define nullptr ((void *)0)
By my understanding, leadership is against changing `NULL` by `nullptr` and not using new constants […]
I also don't think people are against using it. It's just that there is no real advantage of doing this major move at the moment, but I think there is no problem with this conditional macro.
Also, it doesn't give us new functionality, but it rather makes us more complaint to the C23 standard. That's a difference.
@jwerner@chromium.org @maximilian.brune@9elements.com Do you remember the outcome of that discussion?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83459?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I07db866bebfd25f1a60d18a3228ada2957500234
Gerrit-Change-Number: 83459
Gerrit-PatchSet: 26
Gerrit-Owner: Elyes Haouas
ehaouas@noos.fr
Gerrit-Reviewer: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Reviewer: Jakub Czapiga
czapiga@google.com
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-CC: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Jakub Czapiga
czapiga@google.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Attention: Elyes Haouas
ehaouas@noos.fr
Gerrit-Comment-Date: Sun, 29 Sep 2024 15:36:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Elyes Haouas
ehaouas@noos.fr