Change in coreboot[master]: mb/google/octopus/variants/garg: fix LTE power sequence while DUT war...
Kevin Chiu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/46022 )
Change subject: mb/google/octopus/variants/garg: fix LTE power sequence while DUT warmboot ......................................................................
mb/google/octopus/variants/garg: fix LTE power sequence while DUT warmboot
related LTE GPIOs: GPIO_67 - EN_PP3300 GPIO_117 - FULL_CARD_POWER_ON_OFF GPIO_161 - PLT_RST_LTE_L
For DUT power reset: - keep GPIO_67 and GPIO_117 high and - pull down GPIO_161 for 30ms then release it.
BUG=b:167565015 BRANCH=master TEST=build and verify on the DUT with LTE
Change-Id: I825cefb524ddaf9a9cb6add31c2ee0eea484f978 Signed-off-by: Kevin Chiu kevin.chiu@quantatw.com --- M src/mainboard/google/octopus/variants/garg/Makefile.inc 1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/22/46022/1
diff --git a/src/mainboard/google/octopus/variants/garg/Makefile.inc b/src/mainboard/google/octopus/variants/garg/Makefile.inc index ba865e9..7ee7e70 100644 --- a/src/mainboard/google/octopus/variants/garg/Makefile.inc +++ b/src/mainboard/google/octopus/variants/garg/Makefile.inc @@ -2,3 +2,5 @@
ramstage-y += gpio.c ramstage-y += variant.c + +smm-y += variant.c
Kevin Chiu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46022 )
Change subject: mb/google/octopus/variants/garg: fix LTE power sequence while DUT warmboot ......................................................................
Patch Set 1:
This change is ready for review.
Kevin Chiu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46022 )
Change subject: mb/google/octopus/variants/garg: fix LTE power sequence while DUT warmboot ......................................................................
Patch Set 1:
hi reviewers, could you please help review this one? thank you!
Kevin Chiu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46022 )
Change subject: mb/google/octopus/variants/garg: fix LTE power sequence while DUT warmboot ......................................................................
Patch Set 1:
hi reviewers, could you please review this one? thanks
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46022 )
Change subject: mb/google/octopus/variants/garg: fix LTE power sequence while DUT warmboot ......................................................................
Patch Set 1: Code-Review+2
Keith Tzeng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46022 )
Change subject: mb/google/octopus/variants/garg: fix LTE power sequence while DUT warmboot ......................................................................
Patch Set 1:
Could we merge this? thanks.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46022 )
Change subject: mb/google/octopus/variants/garg: fix LTE power sequence while DUT warmboot ......................................................................
Patch Set 1:
(2 comments)
Is the Makefile change, all that is needed? Please elaborate in the commit message.
https://review.coreboot.org/c/coreboot/+/46022/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/46022/1//COMMIT_MSG@16 PS1, Line 16: - pull down GPIO_161 for 30ms then release it. Please name the datasheet name and version, where the power sequence is described in.
https://review.coreboot.org/c/coreboot/+/46022/1//COMMIT_MSG@15 PS1, Line 15: - keep GPIO_67 and GPIO_117 high and : - pull down GPIO_161 for 30ms then release it. Indentation for lists is not needed. You might loosely follow [Markdown][1].
[1]: https://daringfireball.net/projects/markdown/syntax
Hello build bot (Jenkins), Patrick Georgi, Martin Roth, Henry Sun, Justin TerAvest, Marco Chen, Keith Tzeng, Karthik Ramasubramanian,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/46022
to look at the new patch set (#2).
Change subject: mb/google/octopus/variants/garg: fix LTE power sequence while DUT warmboot ......................................................................
mb/google/octopus/variants/garg: fix LTE power sequence while DUT warmboot
invoke LTE power off function to meet LTE power sequence while DUT is in warm boot.
BUG=b:167565015 BRANCH=master TEST=build and verify on the DUT with LTE
Change-Id: I825cefb524ddaf9a9cb6add31c2ee0eea484f978 Signed-off-by: Kevin Chiu kevin.chiu@quantatw.com --- M src/mainboard/google/octopus/variants/garg/Makefile.inc 1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/22/46022/2
Kevin Chiu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46022 )
Change subject: mb/google/octopus/variants/garg: fix LTE power sequence while DUT warmboot ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46022/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/46022/1//COMMIT_MSG@16 PS1, Line 16: - pull down GPIO_161 for 30ms then release it.
Please name the datasheet name and version, where the power sequence is described in.
since this patch aims to invoke the function already existed for reboot power state, so I update the commit msg more concisely. thanks.
Kevin Chiu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46022 )
Change subject: mb/google/octopus/variants/garg: fix LTE power sequence while DUT warmboot ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/46022/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/46022/1//COMMIT_MSG@15 PS1, Line 15: - keep GPIO_67 and GPIO_117 high and : - pull down GPIO_161 for 30ms then release it.
Indentation for lists is not needed. You might loosely follow [Markdown][1]. […]
Done
https://review.coreboot.org/c/coreboot/+/46022/1//COMMIT_MSG@16 PS1, Line 16: - pull down GPIO_161 for 30ms then release it.
since this patch aims to invoke the function already existed for reboot power state, so I update the […]
Done
Marco Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46022 )
Change subject: mb/google/octopus/variants/garg: fix LTE power sequence while DUT warmboot ......................................................................
Patch Set 2: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/46022/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/46022/2//COMMIT_MSG@7 PS2, Line 7: mb/google/octopus/variants/garg: fix LTE power sequence while DUT warmboot nit: too long for this line.
s/variants/var/ s/warmboot/warm boot/
Hello build bot (Jenkins), Patrick Georgi, Martin Roth, Henry Sun, Justin TerAvest, Marco Chen, Keith Tzeng, Karthik Ramasubramanian,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/46022
to look at the new patch set (#3).
Change subject: mb/google/octopus: fix LTE power sequence in reboot state for garg ......................................................................
mb/google/octopus: fix LTE power sequence in reboot state for garg
invoke LTE power off function to meet LTE power sequence while DUT is in reboot state.
BUG=b:167565015 BRANCH=master TEST=build and verify on the DUT with LTE
Change-Id: I825cefb524ddaf9a9cb6add31c2ee0eea484f978 Signed-off-by: Kevin Chiu kevin.chiu@quantatw.com --- M src/mainboard/google/octopus/variants/garg/Makefile.inc 1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/22/46022/3
Kevin Chiu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46022 )
Change subject: mb/google/octopus: fix LTE power sequence in reboot state for garg ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46022/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/46022/2//COMMIT_MSG@7 PS2, Line 7: mb/google/octopus/variants/garg: fix LTE power sequence while DUT warmboot
nit: too long for this line. […]
Done
Henry Sun has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46022 )
Change subject: mb/google/octopus: fix LTE power sequence in reboot state for garg ......................................................................
Patch Set 3: Code-Review+1
Marco Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46022 )
Change subject: mb/google/octopus: fix LTE power sequence in reboot state for garg ......................................................................
Patch Set 4: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/46022/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/46022/4//COMMIT_MSG@7 PS4, Line 7: mb/google/octopus: fix LTE power sequence in reboot state for garg mb/google/octopus/var/garg: fix LTE power sequence in reboot state
Hello build bot (Jenkins), Patrick Georgi, Martin Roth, Henry Sun, Justin TerAvest, Marco Chen, Keith Tzeng, Karthik Ramasubramanian,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/46022
to look at the new patch set (#5).
Change subject: mb/google/octopus/var/garg: fix LTE power sequence in reboot state ......................................................................
mb/google/octopus/var/garg: fix LTE power sequence in reboot state
invoke LTE power off function to meet LTE power sequence while DUT is in reboot state.
BUG=b:167565015 BRANCH=master TEST=build and verify on the DUT with LTE
Change-Id: I825cefb524ddaf9a9cb6add31c2ee0eea484f978 Signed-off-by: Kevin Chiu kevin.chiu@quantatw.com --- M src/mainboard/google/octopus/variants/garg/Makefile.inc 1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/22/46022/5
Kevin Chiu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46022 )
Change subject: mb/google/octopus/var/garg: fix LTE power sequence in reboot state ......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46022/4//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/46022/4//COMMIT_MSG@7 PS4, Line 7: mb/google/octopus: fix LTE power sequence in reboot state for garg
mb/google/octopus/var/garg: fix LTE power sequence in reboot state
Done
Marco Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46022 )
Change subject: mb/google/octopus/var/garg: fix LTE power sequence in reboot state ......................................................................
Patch Set 5: Code-Review+2
Keith Tzeng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46022 )
Change subject: mb/google/octopus/var/garg: fix LTE power sequence in reboot state ......................................................................
Patch Set 5:
please help merge this, thanks.
EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46022 )
Change subject: mb/google/octopus/var/garg: fix LTE power sequence in reboot state ......................................................................
Patch Set 5:
branch should be octopus?
Marco Chen has uploaded a new patch set (#6) to the change originally created by Kevin Chiu. ( https://review.coreboot.org/c/coreboot/+/46022 )
Change subject: mb/google/octopus/var/garg: fix LTE power sequence in reboot state ......................................................................
mb/google/octopus/var/garg: fix LTE power sequence in reboot state
invoke LTE power off function to meet LTE power sequence while DUT is in reboot state.
BUG=b:167565015 BRANCH=octopus TEST=build and verify on the DUT with LTE
Change-Id: I825cefb524ddaf9a9cb6add31c2ee0eea484f978 Signed-off-by: Kevin Chiu kevin.chiu@quantatw.com --- M src/mainboard/google/octopus/variants/garg/Makefile.inc 1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/22/46022/6
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46022 )
Change subject: mb/google/octopus/var/garg: fix LTE power sequence in reboot state ......................................................................
Patch Set 6: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/46022 )
Change subject: mb/google/octopus/var/garg: fix LTE power sequence in reboot state ......................................................................
mb/google/octopus/var/garg: fix LTE power sequence in reboot state
invoke LTE power off function to meet LTE power sequence while DUT is in reboot state.
BUG=b:167565015 BRANCH=octopus TEST=build and verify on the DUT with LTE
Change-Id: I825cefb524ddaf9a9cb6add31c2ee0eea484f978 Signed-off-by: Kevin Chiu kevin.chiu@quantatw.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/46022 Reviewed-by: Patrick Georgi pgeorgi@google.com Reviewed-by: Marco Chen marcochen@google.com Reviewed-by: Henry Sun henrysun@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/octopus/variants/garg/Makefile.inc 1 file changed, 2 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved Marco Chen: Looks good to me, approved Henry Sun: Looks good to me, but someone else must approve
diff --git a/src/mainboard/google/octopus/variants/garg/Makefile.inc b/src/mainboard/google/octopus/variants/garg/Makefile.inc index ba865e9..7ee7e70 100644 --- a/src/mainboard/google/octopus/variants/garg/Makefile.inc +++ b/src/mainboard/google/octopus/variants/garg/Makefile.inc @@ -2,3 +2,5 @@
ramstage-y += gpio.c ramstage-y += variant.c + +smm-y += variant.c
-
EricR Lai (Code Review) -
Henry Sun (Code Review)
-
Karthik Ramasubramanian (Code Review)
-
Keith Tzeng (Code Review)
-
Kevin Chiu (Code Review)
-
Marco Chen (Code Review)
-
Patrick Georgi (Code Review)
-
Paul Menzel (Code Review)