build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29847 )
Change subject: src: Remove duplicated round up function
......................................................................
Patch Set 6:
(2 comments)
https://review.coreboot.org/#/c/29847/6/src/soc/nvidia/tegra210/include/soc/...
File src/soc/nvidia/tegra210/include/soc/clock.h:
https://review.coreboot.org/#/c/29847/6/src/soc/nvidia/tegra210/include/soc/...
PS6, Line 327: #define get_i2c_clk_div(src,freq) (DIV_ROUND_UP(src, (freq) * (0x19 + 1) * 8) - 1)
line over 80 characters
https://review.coreboot.org/#/c/29847/6/src/soc/nvidia/tegra210/include/soc/...
PS6, Line 327: #define get_i2c_clk_div(src,freq) (DIV_ROUND_UP(src, (freq) * (0x19 + 1) * 8) - 1)
space required after that ',' (ctx:VxV)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/29847
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9aabc3fbe7834834c92d6ba59ff0005986622a34
Gerrit-Change-Number: 29847
Gerrit-PatchSet: 6
Gerrit-Owner: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Comment-Date: Wed, 28 Nov 2018 12:11:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment