Attention is currently required from: Angel Pons, Christian Walter, Felix Held, Fred Reitberger, Jason Glenesk, Patrick Rudolph, Sean Rhodes.
Nicholas Chin has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/84588?usp=email )
Change subject: mb/*: Explicitly include static.h for config_of_soc ......................................................................
mb/*: Explicitly include static.h for config_of_soc
As per commit 865173153760 ("sconfig: Move config_of_soc from device.h to static.h"), sources that require access to the devicetree should directly include static.h so that it can be removed from device.h, eliminating unnecessary dependencies on static.h for files that only need the types and function declarations in device.h.
Change-Id: Ia793666fda47678764fd33891fddb4aecf207bd4 Signed-off-by: Nicholas Chin nic.c3.14@gmail.com --- M src/mainboard/amd/bilby/mainboard.c M src/mainboard/amd/birman/update_devicetree_phoenix_opensil.c M src/mainboard/amd/mandolin/mainboard.c M src/mainboard/google/dedede/mainboard.c M src/mainboard/google/fizz/mainboard.c M src/mainboard/google/poppy/variants/nami/mainboard.c M src/mainboard/google/poppy/variants/nautilus/mainboard.c M src/mainboard/google/puff/variants/baseboard/mainboard.c M src/mainboard/intel/adlrvp/ramstage.c M src/mainboard/lattepanda/mu/ramstage.c M src/mainboard/prodrive/hermes/mainboard.c M src/mainboard/starlabs/byte_adl/variants/mk_ii/devtree.c M src/mainboard/starlabs/lite/devtree.c M src/mainboard/starlabs/starbook/variants/adl/devtree.c M src/mainboard/starlabs/starbook/variants/cml/devtree.c M src/mainboard/starlabs/starbook/variants/kbl/devtree.c M src/mainboard/starlabs/starbook/variants/rpl/devtree.c M src/mainboard/starlabs/starbook/variants/tgl/devtree.c M src/mainboard/starlabs/starlite_adl/variants/mk_v/devtree.c 19 files changed, 19 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/88/84588/1
diff --git a/src/mainboard/amd/bilby/mainboard.c b/src/mainboard/amd/bilby/mainboard.c index 7af66e6..11d3a60 100644 --- a/src/mainboard/amd/bilby/mainboard.c +++ b/src/mainboard/amd/bilby/mainboard.c @@ -10,6 +10,7 @@ #include <soc/southbridge.h> #include <soc/pci_devs.h> #include <soc/platform_descriptors.h> +#include <static.h> #include <types.h> #include <commonlib/helpers.h> #include <soc/amd/picasso/chip.h> diff --git a/src/mainboard/amd/birman/update_devicetree_phoenix_opensil.c b/src/mainboard/amd/birman/update_devicetree_phoenix_opensil.c index f0060b8..2640e74 100644 --- a/src/mainboard/amd/birman/update_devicetree_phoenix_opensil.c +++ b/src/mainboard/amd/birman/update_devicetree_phoenix_opensil.c @@ -3,6 +3,7 @@ #include <device/device.h> #include <soc/amd/phoenix/chip.h> #include <soc/soc_util.h> +#include <static.h> #include <vendorcode/amd/opensil/chip/mpio/chip.h> #include "display_card_type.h" #include "update_devicetree.h" diff --git a/src/mainboard/amd/mandolin/mainboard.c b/src/mainboard/amd/mandolin/mainboard.c index 7975c10..c044a81 100644 --- a/src/mainboard/amd/mandolin/mainboard.c +++ b/src/mainboard/amd/mandolin/mainboard.c @@ -8,6 +8,7 @@ #include <soc/cpu.h> #include <soc/southbridge.h> #include <soc/pci_devs.h> +#include <static.h> #include <types.h> #include <commonlib/helpers.h> #include <soc/amd/picasso/chip.h> diff --git a/src/mainboard/google/dedede/mainboard.c b/src/mainboard/google/dedede/mainboard.c index aae4155..a668412 100644 --- a/src/mainboard/google/dedede/mainboard.c +++ b/src/mainboard/google/dedede/mainboard.c @@ -11,6 +11,7 @@ #include <ec/ec.h> #include <security/tpm/tss.h> #include <soc/soc_chip.h> +#include <static.h> #include <timer.h> #include <vb2_api.h>
diff --git a/src/mainboard/google/fizz/mainboard.c b/src/mainboard/google/fizz/mainboard.c index 795d96e..e908b9e 100644 --- a/src/mainboard/google/fizz/mainboard.c +++ b/src/mainboard/google/fizz/mainboard.c @@ -14,6 +14,7 @@ #include <smbios.h> #include <soc/pci_devs.h> #include <soc/nhlt.h> +#include <static.h> #include <stdio.h> #include <timer.h>
diff --git a/src/mainboard/google/poppy/variants/nami/mainboard.c b/src/mainboard/google/poppy/variants/nami/mainboard.c index 7bdfb5e..c5ee5b9 100644 --- a/src/mainboard/google/poppy/variants/nami/mainboard.c +++ b/src/mainboard/google/poppy/variants/nami/mainboard.c @@ -13,6 +13,7 @@ #include <intelblocks/power_limit.h> #include <smbios.h> #include <soc/ramstage.h> +#include <static.h> #include <stdio.h> #include <variant/sku.h> #include <gpio.h> diff --git a/src/mainboard/google/poppy/variants/nautilus/mainboard.c b/src/mainboard/google/poppy/variants/nautilus/mainboard.c index b77513b..02f861f 100644 --- a/src/mainboard/google/poppy/variants/nautilus/mainboard.c +++ b/src/mainboard/google/poppy/variants/nautilus/mainboard.c @@ -6,6 +6,7 @@ #include <device/device.h> #include <device/pci_ops.h> #include <smbios.h> +#include <static.h> #include <stdio.h> #include <variant/sku.h>
diff --git a/src/mainboard/google/puff/variants/baseboard/mainboard.c b/src/mainboard/google/puff/variants/baseboard/mainboard.c index e0c3440..b455c6d 100644 --- a/src/mainboard/google/puff/variants/baseboard/mainboard.c +++ b/src/mainboard/google/puff/variants/baseboard/mainboard.c @@ -12,6 +12,7 @@ #include <gpio.h> #include <intelblocks/power_limit.h> #include <soc/pci_devs.h> +#include <static.h> #include <timer.h>
#define GPIO_HDMI_HPD GPP_E13 diff --git a/src/mainboard/intel/adlrvp/ramstage.c b/src/mainboard/intel/adlrvp/ramstage.c index 3bdc230..fd8e203 100644 --- a/src/mainboard/intel/adlrvp/ramstage.c +++ b/src/mainboard/intel/adlrvp/ramstage.c @@ -8,6 +8,7 @@ #include <soc/gpio_soc_defs.h> #include <soc/pci_devs.h> #include <soc/soc_chip.h> +#include <static.h> #include <string.h> #include <drivers/intel/dptf/chip.h> #include "board_id.h" diff --git a/src/mainboard/lattepanda/mu/ramstage.c b/src/mainboard/lattepanda/mu/ramstage.c index 952524e..e10b179 100644 --- a/src/mainboard/lattepanda/mu/ramstage.c +++ b/src/mainboard/lattepanda/mu/ramstage.c @@ -8,6 +8,7 @@ #include <soc/gpio_soc_defs.h> #include <soc/pci_devs.h> #include <soc/soc_chip.h> +#include <static.h> #include <string.h> #include <drivers/intel/dptf/chip.h> #include <intelblocks/power_limit.h> diff --git a/src/mainboard/prodrive/hermes/mainboard.c b/src/mainboard/prodrive/hermes/mainboard.c index 6d0da8d..4ae8454 100644 --- a/src/mainboard/prodrive/hermes/mainboard.c +++ b/src/mainboard/prodrive/hermes/mainboard.c @@ -16,6 +16,7 @@ #include <intelblocks/pmclib.h> #include <smbios.h> #include <soc/pm.h> +#include <static.h> #include <stdio.h> #include <string.h> #include <types.h> diff --git a/src/mainboard/starlabs/byte_adl/variants/mk_ii/devtree.c b/src/mainboard/starlabs/byte_adl/variants/mk_ii/devtree.c index 96e0b93..e236c45 100644 --- a/src/mainboard/starlabs/byte_adl/variants/mk_ii/devtree.c +++ b/src/mainboard/starlabs/byte_adl/variants/mk_ii/devtree.c @@ -5,6 +5,7 @@ #include <device/device.h> #include <device/pci_def.h> #include <option.h> +#include <static.h> #include <types.h> #include <variants.h>
diff --git a/src/mainboard/starlabs/lite/devtree.c b/src/mainboard/starlabs/lite/devtree.c index d3f8100..f258804 100644 --- a/src/mainboard/starlabs/lite/devtree.c +++ b/src/mainboard/starlabs/lite/devtree.c @@ -4,6 +4,7 @@ #include <device/device.h> #include <device/pci_def.h> #include <option.h> +#include <static.h> #include <types.h> #include <variants.h>
diff --git a/src/mainboard/starlabs/starbook/variants/adl/devtree.c b/src/mainboard/starlabs/starbook/variants/adl/devtree.c index 27ab6c9..60367d0 100644 --- a/src/mainboard/starlabs/starbook/variants/adl/devtree.c +++ b/src/mainboard/starlabs/starbook/variants/adl/devtree.c @@ -5,6 +5,7 @@ #include <device/device.h> #include <device/pci_def.h> #include <option.h> +#include <static.h> #include <types.h> #include <variants.h>
diff --git a/src/mainboard/starlabs/starbook/variants/cml/devtree.c b/src/mainboard/starlabs/starbook/variants/cml/devtree.c index 95a5d44..20b3b17 100644 --- a/src/mainboard/starlabs/starbook/variants/cml/devtree.c +++ b/src/mainboard/starlabs/starbook/variants/cml/devtree.c @@ -5,6 +5,7 @@ #include <device/device.h> #include <device/pci_def.h> #include <option.h> +#include <static.h> #include <types.h> #include <variants.h>
diff --git a/src/mainboard/starlabs/starbook/variants/kbl/devtree.c b/src/mainboard/starlabs/starbook/variants/kbl/devtree.c index 38017dc..b6ff153 100644 --- a/src/mainboard/starlabs/starbook/variants/kbl/devtree.c +++ b/src/mainboard/starlabs/starbook/variants/kbl/devtree.c @@ -5,6 +5,7 @@ #include <device/device.h> #include <device/pci_def.h> #include <option.h> +#include <static.h> #include <types.h> #include <variants.h>
diff --git a/src/mainboard/starlabs/starbook/variants/rpl/devtree.c b/src/mainboard/starlabs/starbook/variants/rpl/devtree.c index b190865..79d8a28 100644 --- a/src/mainboard/starlabs/starbook/variants/rpl/devtree.c +++ b/src/mainboard/starlabs/starbook/variants/rpl/devtree.c @@ -5,6 +5,7 @@ #include <device/device.h> #include <device/pci_def.h> #include <option.h> +#include <static.h> #include <types.h> #include <variants.h>
diff --git a/src/mainboard/starlabs/starbook/variants/tgl/devtree.c b/src/mainboard/starlabs/starbook/variants/tgl/devtree.c index 7c94430..f81a151 100644 --- a/src/mainboard/starlabs/starbook/variants/tgl/devtree.c +++ b/src/mainboard/starlabs/starbook/variants/tgl/devtree.c @@ -5,6 +5,7 @@ #include <device/device.h> #include <device/pci_def.h> #include <option.h> +#include <static.h> #include <types.h> #include <variants.h>
diff --git a/src/mainboard/starlabs/starlite_adl/variants/mk_v/devtree.c b/src/mainboard/starlabs/starlite_adl/variants/mk_v/devtree.c index b07fc4c..aa0c1bc 100644 --- a/src/mainboard/starlabs/starlite_adl/variants/mk_v/devtree.c +++ b/src/mainboard/starlabs/starlite_adl/variants/mk_v/devtree.c @@ -5,6 +5,7 @@ #include <device/device.h> #include <device/pci_def.h> #include <option.h> +#include <static.h> #include <types.h> #include <variants.h>
-
Nicholas Chin (Code Review)