Change in coreboot[master]: [RFC] device: Introduce new method for setting device states

[Michael Niewöhner (Code Review)]

Attention is currently required from:  Felix Singer, Nico Huber, Raul Rangel, Furquan Shaikh, Matt DeVillier, Angel Pons, Patrick Rudolph, Felix Held.
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52493 )

Change subject: [RFC] device: Introduce new method for setting device states
......................................................................

Patch Set 21:

(1 comment)

File src/soc/intel/skylake/chip.c:

https://review.coreboot.org/c/coreboot/+/52493/comment/366742e3_fd6e6787 
PS13, Line 461: if (!xdci_can_enable())
              : 		params->XdciEnable = 0;
> I would say the name depends on the exact implementation. If you decide for […]

I had the idea that we could set related UPDs in that function, too, like UPDs that depend on the enabled state of the device e.g. PchHdaEnable, PchHdaVcType etc. or ScsEmmcHs400Enabled, PchScsEmmcHs400DllDataValid, PchScsEmmcHs400RxStrobeDll1.

This way, these UPDs would be grouped together in these functions (on function per device). However, we would have to pass that FSP*_UPD pointer around, which is pretty ugly.