Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/54357 )
Change subject: mainboard: Use decimal for `device cpu_cluster 0x0 on` ......................................................................
mainboard: Use decimal for `device cpu_cluster 0x0 on`
Most boards use `device cpu_cluster 0 on` with zero written in decimal. For the sake of consistency, update the remaining boards to follow suit.
Change-Id: I083c8f8e9b38ddcc217dc8bf17ae3c9473ba77e9 Signed-off-by: Angel Pons th3fanbus@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/54357 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Arthur Heymans arthur@aheymans.xyz --- M src/mainboard/apple/macbookair4_2/devicetree.cb M src/mainboard/asrock/b75pro3-m/devicetree.cb M src/mainboard/asus/h61m-cs/devicetree.cb M src/mainboard/asus/p8h61-m_pro/devicetree.cb M src/mainboard/asus/p8z77-m_pro/devicetree.cb M src/mainboard/compulab/intense_pc/devicetree.cb M src/mainboard/hp/compaq_8200_elite_sff/devicetree.cb M src/mainboard/hp/snb_ivb_laptops/devicetree.cb M src/mainboard/hp/z220_sff_workstation/devicetree.cb M src/mainboard/intel/dcp847ske/devicetree.cb M src/mainboard/lenovo/s230u/devicetree.cb M src/mainboard/lenovo/t430/devicetree.cb M src/mainboard/lenovo/t440p/devicetree.cb M src/mainboard/lenovo/x131e/devicetree.cb M src/mainboard/msi/ms7707/devicetree.cb M src/mainboard/sapphire/pureplatinumh61/devicetree.cb 16 files changed, 16 insertions(+), 16 deletions(-)
Approvals: build bot (Jenkins): Verified Arthur Heymans: Looks good to me, approved
diff --git a/src/mainboard/apple/macbookair4_2/devicetree.cb b/src/mainboard/apple/macbookair4_2/devicetree.cb index ee192cf..b9c9c15 100644 --- a/src/mainboard/apple/macbookair4_2/devicetree.cb +++ b/src/mainboard/apple/macbookair4_2/devicetree.cb @@ -13,7 +13,7 @@ register "gpu_panel_power_down_delay" = "500" register "gpu_panel_power_up_delay" = "2000" register "gpu_pch_backlight" = "0x13121312" - device cpu_cluster 0x0 on + device cpu_cluster 0 on chip cpu/intel/model_206ax register "acpi_c1" = "1" register "acpi_c2" = "3" diff --git a/src/mainboard/asrock/b75pro3-m/devicetree.cb b/src/mainboard/asrock/b75pro3-m/devicetree.cb index af69d58..6333c16 100644 --- a/src/mainboard/asrock/b75pro3-m/devicetree.cb +++ b/src/mainboard/asrock/b75pro3-m/devicetree.cb @@ -13,7 +13,7 @@ register "gpu_panel_power_down_delay" = "0" register "gpu_panel_power_up_delay" = "0" register "gpu_pch_backlight" = "0x00000000" - device cpu_cluster 0x0 on + device cpu_cluster 0 on chip cpu/intel/model_206ax register "acpi_c1" = "1" register "acpi_c2" = "3" diff --git a/src/mainboard/asus/h61m-cs/devicetree.cb b/src/mainboard/asus/h61m-cs/devicetree.cb index 60f8191..adb39a7 100644 --- a/src/mainboard/asus/h61m-cs/devicetree.cb +++ b/src/mainboard/asus/h61m-cs/devicetree.cb @@ -1,7 +1,7 @@ ## SPDX-License-Identifier: GPL-2.0-or-later
chip northbridge/intel/sandybridge - device cpu_cluster 0x0 on + device cpu_cluster 0 on chip cpu/intel/model_206ax register "acpi_c1" = "1" register "acpi_c2" = "3" diff --git a/src/mainboard/asus/p8h61-m_pro/devicetree.cb b/src/mainboard/asus/p8h61-m_pro/devicetree.cb index 60e54ae..804f272 100644 --- a/src/mainboard/asus/p8h61-m_pro/devicetree.cb +++ b/src/mainboard/asus/p8h61-m_pro/devicetree.cb @@ -1,7 +1,7 @@ ## SPDX-License-Identifier: GPL-2.0-only
chip northbridge/intel/sandybridge - device cpu_cluster 0x0 on + device cpu_cluster 0 on chip cpu/intel/model_206ax register "acpi_c1" = "1" register "acpi_c2" = "3" diff --git a/src/mainboard/asus/p8z77-m_pro/devicetree.cb b/src/mainboard/asus/p8z77-m_pro/devicetree.cb index 1d1a244..330fa0d 100644 --- a/src/mainboard/asus/p8z77-m_pro/devicetree.cb +++ b/src/mainboard/asus/p8z77-m_pro/devicetree.cb @@ -1,7 +1,7 @@ ## SPDX-License-Identifier: GPL-2.0-only
chip northbridge/intel/sandybridge - device cpu_cluster 0x0 on + device cpu_cluster 0 on chip cpu/intel/model_206ax register "acpi_c1" = "1" register "acpi_c2" = "3" diff --git a/src/mainboard/compulab/intense_pc/devicetree.cb b/src/mainboard/compulab/intense_pc/devicetree.cb index b48dae3..9f28a14 100644 --- a/src/mainboard/compulab/intense_pc/devicetree.cb +++ b/src/mainboard/compulab/intense_pc/devicetree.cb @@ -6,7 +6,7 @@ register "gpu_dp_c_hotplug" = "4" register "gpu_dp_d_hotplug" = "4"
- device cpu_cluster 0x0 on + device cpu_cluster 0 on chip cpu/intel/model_206ax # FIXME: check all registers register "acpi_c1" = "1" register "acpi_c2" = "3" diff --git a/src/mainboard/hp/compaq_8200_elite_sff/devicetree.cb b/src/mainboard/hp/compaq_8200_elite_sff/devicetree.cb index db902be..b3b670e 100644 --- a/src/mainboard/hp/compaq_8200_elite_sff/devicetree.cb +++ b/src/mainboard/hp/compaq_8200_elite_sff/devicetree.cb @@ -6,7 +6,7 @@ register "gpu_dp_c_hotplug" = "0" register "gpu_dp_d_hotplug" = "0"
- device cpu_cluster 0x0 on + device cpu_cluster 0 on chip cpu/intel/model_206ax register "acpi_c1" = "1" register "acpi_c2" = "3" diff --git a/src/mainboard/hp/snb_ivb_laptops/devicetree.cb b/src/mainboard/hp/snb_ivb_laptops/devicetree.cb index a449200..c57ffb6 100644 --- a/src/mainboard/hp/snb_ivb_laptops/devicetree.cb +++ b/src/mainboard/hp/snb_ivb_laptops/devicetree.cb @@ -15,7 +15,7 @@ register "gpu_panel_power_down_delay" = "230" register "gpu_panel_power_up_delay" = "300" register "gpu_pch_backlight" = "0x02880288" - device cpu_cluster 0x0 on + device cpu_cluster 0 on chip cpu/intel/model_206ax register "acpi_c1" = "1" register "acpi_c2" = "3" diff --git a/src/mainboard/hp/z220_sff_workstation/devicetree.cb b/src/mainboard/hp/z220_sff_workstation/devicetree.cb index f1ec5e7..d884635 100644 --- a/src/mainboard/hp/z220_sff_workstation/devicetree.cb +++ b/src/mainboard/hp/z220_sff_workstation/devicetree.cb @@ -6,7 +6,7 @@ register "gpu_dp_c_hotplug" = "0" register "gpu_dp_d_hotplug" = "0"
- device cpu_cluster 0x0 on + device cpu_cluster 0 on chip cpu/intel/model_206ax register "acpi_c1" = "1" register "acpi_c2" = "3" diff --git a/src/mainboard/intel/dcp847ske/devicetree.cb b/src/mainboard/intel/dcp847ske/devicetree.cb index 7a56844..0075b94 100644 --- a/src/mainboard/intel/dcp847ske/devicetree.cb +++ b/src/mainboard/intel/dcp847ske/devicetree.cb @@ -11,7 +11,7 @@ # Enable DVI Hotplug with 6ms pulse register "gpu_dp_b_hotplug" = "0x06"
- device cpu_cluster 0x0 on + device cpu_cluster 0 on chip cpu/intel/model_206ax # Magic APIC ID to locate this chip device lapic 0x0 on end diff --git a/src/mainboard/lenovo/s230u/devicetree.cb b/src/mainboard/lenovo/s230u/devicetree.cb index eb92d78..9546c3e 100644 --- a/src/mainboard/lenovo/s230u/devicetree.cb +++ b/src/mainboard/lenovo/s230u/devicetree.cb @@ -11,7 +11,7 @@ register "gpu_panel_power_down_delay" = "500" register "gpu_panel_power_up_delay" = "600" register "gpu_pch_backlight" = "0x041e041e" - device cpu_cluster 0x0 on + device cpu_cluster 0 on chip cpu/intel/model_206ax register "acpi_c1" = "1" register "acpi_c2" = "3" diff --git a/src/mainboard/lenovo/t430/devicetree.cb b/src/mainboard/lenovo/t430/devicetree.cb index cafc2df..3c5c3c3 100644 --- a/src/mainboard/lenovo/t430/devicetree.cb +++ b/src/mainboard/lenovo/t430/devicetree.cb @@ -14,7 +14,7 @@ register "gpu_cpu_backlight" = "0x1155" register "gpu_pch_backlight" = "0x11551155"
- device cpu_cluster 0x0 on + device cpu_cluster 0 on chip cpu/intel/model_206ax # FIXME: check all registers register "acpi_c1" = "1" register "acpi_c2" = "3" diff --git a/src/mainboard/lenovo/t440p/devicetree.cb b/src/mainboard/lenovo/t440p/devicetree.cb index 8db28cb..590004a 100644 --- a/src/mainboard/lenovo/t440p/devicetree.cb +++ b/src/mainboard/lenovo/t440p/devicetree.cb @@ -13,7 +13,7 @@ .backlight_pwm_hz = 220, }" register "ec_present" = "true" - device cpu_cluster 0x0 on + device cpu_cluster 0 on chip cpu/intel/haswell device lapic 0x0 on end device lapic 0xacac off end diff --git a/src/mainboard/lenovo/x131e/devicetree.cb b/src/mainboard/lenovo/x131e/devicetree.cb index 2627fae..00b5574 100644 --- a/src/mainboard/lenovo/x131e/devicetree.cb +++ b/src/mainboard/lenovo/x131e/devicetree.cb @@ -14,7 +14,7 @@ register "gpu_cpu_backlight" = "0x1155" register "gpu_pch_backlight" = "0x11551155"
- device cpu_cluster 0x0 on + device cpu_cluster 0 on chip cpu/intel/model_206ax # Magic APIC ID to locate this chip device lapic 0x0 on end diff --git a/src/mainboard/msi/ms7707/devicetree.cb b/src/mainboard/msi/ms7707/devicetree.cb index 2ccf7c6..f006e13 100644 --- a/src/mainboard/msi/ms7707/devicetree.cb +++ b/src/mainboard/msi/ms7707/devicetree.cb @@ -1,5 +1,5 @@ chip northbridge/intel/sandybridge - device cpu_cluster 0x0 on + device cpu_cluster 0 on chip cpu/intel/model_206ax register "acpi_c1" = "1" register "acpi_c2" = "3" diff --git a/src/mainboard/sapphire/pureplatinumh61/devicetree.cb b/src/mainboard/sapphire/pureplatinumh61/devicetree.cb index 82117fb..adc65cf 100644 --- a/src/mainboard/sapphire/pureplatinumh61/devicetree.cb +++ b/src/mainboard/sapphire/pureplatinumh61/devicetree.cb @@ -1,7 +1,7 @@ # SPDX-License-Identifier: GPL-2.0-or-later
chip northbridge/intel/sandybridge - device cpu_cluster 0x0 on + device cpu_cluster 0 on chip cpu/intel/model_206ax register "acpi_c1" = "1" register "acpi_c2" = "3"
-
Patrick Georgi (Code Review)