Change in coreboot[master]: arch/x86/acpi_s3.c: Only call APM with CONFIG_HAVE_SMI_HANDLER

[Arthur Heymans (Code Review)]

Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/46381 )

Change subject: arch/x86/acpi_s3.c: Only call APM with CONFIG_HAVE_SMI_HANDLER
......................................................................

arch/x86/acpi_s3.c: Only call APM with CONFIG_HAVE_SMI_HANDLER

Change-Id: If38c53cba7efd39a8894fde956d2f6aa06620e9a
Signed-off-by: Arthur Heymans 
---
M src/arch/x86/acpi_s3.c
1 file changed, 2 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/81/46381/1

diff --git a/src/arch/x86/acpi_s3.c b/src/arch/x86/acpi_s3.c
index 2802bd3..e8ef600 100644
--- a/src/arch/x86/acpi_s3.c
+++ b/src/arch/x86/acpi_s3.c
@@ -74,7 +74,8 @@
 void __noreturn acpi_resume(void *wake_vec)
 {
    /* Restore GNVS pointer in SMM if found. */
-	apm_control(APM_CNT_GNVS_UPDATE);
+	if (CONFIG(HAVE_SMI_HANDLER))
+		apm_control(APM_CNT_GNVS_UPDATE);

/* Call mainboard resume handler first, if defined. */
    mainboard_suspend_resume();

[Kyösti Mälkki (Code Review)]

Attention is currently required from: Arthur Heymans.
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46381 )

Change subject: arch/x86/acpi_s3.c: Only call APM with CONFIG_HAVE_SMI_HANDLER
......................................................................

Patch Set 1:

(1 comment)

Patchset:

PS1: 
Abandon, APM_CNT_GNVS_UPDATE has been dropped.

[Arthur Heymans (Code Review)]

Arthur Heymans has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/46381 )

Change subject: arch/x86/acpi_s3.c: Only call APM with CONFIG_HAVE_SMI_HANDLER
......................................................................

Abandoned

obsolete