Attention is currently required from: Patrick Rudolph. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59577 )
Change subject: WIP: drivers/intel/retimer: Map correct physical port to EC port ......................................................................
Patch Set 1:
(6 comments)
File src/drivers/intel/usb4/retimer/retimer.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134112): https://review.coreboot.org/c/coreboot/+/59577/comment/93c58e8a_da7bc84c PS1, Line 349: for (uint8_t i = 0; i < MAX_TYPE_C_PORTS; i++) that open brace { should be on the previous line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134112): https://review.coreboot.org/c/coreboot/+/59577/comment/efd25f1a_7af3b037 PS1, Line 352: printk(BIOS_ERR, "USB Type-C %d mapped to EC port %d\n", i, ec_port); trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134112): https://review.coreboot.org/c/coreboot/+/59577/comment/0874af20_d1d5e3bf PS1, Line 352: printk(BIOS_ERR, "USB Type-C %d mapped to EC port %d\n", i, ec_port); line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134112): https://review.coreboot.org/c/coreboot/+/59577/comment/8a3d73a7_6a05f62d PS1, Line 357: ec_port++; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134112): https://review.coreboot.org/c/coreboot/+/59577/comment/d49470f7_6a3d0add PS1, Line 357: ec_port++; please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134112): https://review.coreboot.org/c/coreboot/+/59577/comment/b03c2cc5_12b9ef2d PS1, Line 357: ec_port++; please, no spaces at the start of a line