Attention is currently required from: Michał Żygowski. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62070 )
Change subject: KGPE-D16: Add minimal source for bootblock from 4.11_branch ......................................................................
Patch Set 1:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/62070/comment/9da5e7df_73325a58 PS1, Line 7: minimal "minimal" to achieve what?
https://review.coreboot.org/c/coreboot/+/62070/comment/a59ab84e_d2c71bb4 PS1, Line 10: for bootblock and a part of romstage There's also ramstage code. I wonder if it isn't just everything?
https://review.coreboot.org/c/coreboot/+/62070/comment/396bca31_d22b8cb3 PS1, Line 11: buildable If it doesn't build right away, it won't pass Jenkins.
Patchset:
PS1: I guess some things need to be reviewed at once, e.g. `cache_as_ram.inc`. But generally it's best for review to have the smallest possible, still cohesive chunks.
The best example I remember to add a platform was AMD Cezanne.
-
Nico Huber (Code Review)