[XS] Change in coreboot[master]: mb/google/nissa/var/joxer: Remove VBOOT_GSC_BOARD_ID config - coreboot-gerrit

6 Jun 2023


      Attention is currently required from: Eric Lai, Himanshu Sahdev, Julius Werner, Kangheui Won, Tarun Tuli, Yu-Ping Wu.
Reka Norman has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75641?usp=email )
Change subject: mb/google/nissa/var/joxer: Remove VBOOT_GSC_BOARD_ID config
......................................................................
Patch Set 2:
(1 comment)
File src/mainboard/google/brya/Kconfig:
https://review.coreboot.org/c/coreboot/+/75641/comment/5622e4f2_bf4047ec :
PS1, Line 295: config VBOOT_GSC_BOARD_ID
...
I think using a config to store the default value is fine even if we don't override it in practice. […]
Marking resolved, feel free to reopen.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/75641?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7dda8ad59046a1dd9a28595e037eda86e91c98df
Gerrit-Change-Number: 75641
Gerrit-PatchSet: 2
Gerrit-Owner: Reka Norman rekanorman@chromium.org
Gerrit-Reviewer: Eric Lai eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: Kangheui Won khwon@chromium.org
Gerrit-Reviewer: Tarun Tuli taruntuli@google.com
Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Himanshu Sahdev himanshu.sahdev@intel.com
Gerrit-CC: Reka Norman rekanorman@google.com
Gerrit-Attention: Tarun Tuli taruntuli@google.com
Gerrit-Attention: Kangheui Won khwon@chromium.org
Gerrit-Attention: Himanshu Sahdev himanshu.sahdev@intel.com
Gerrit-Attention: Julius Werner jwerner@chromium.org
Gerrit-Attention: Eric Lai eric_lai@quanta.corp-partner.google.com
Gerrit-Attention: Yu-Ping Wu yupingso@google.com
Gerrit-Comment-Date: Mon, 05 Jun 2023 23:31:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Reka Norman rekanorman@chromium.org
Comment-In-Reply-To: Himanshu Sahdev himanshu.sahdev@intel.com
Gerrit-MessageType: comment