Change in coreboot[master]: soc/amd/picasso: Avoid NULL pointer dereference

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

John Zhao (Code Review)

26 Jun 2020 26 Jun '20

5:03 p.m.

John Zhao has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/42837 )

Change subject: soc/amd/picasso: Avoid NULL pointer dereference ......................................................................

soc/amd/picasso: Avoid NULL pointer dereference

Coverity detects dereferencing a pointer that might be "NULL" when calling acpigen_write_scope. Add sanity check for scope to prevent NULL pointer dereference.

BUG=CID 1429980 TEST=None

Signed-off-by: John Zhao john.zhao@intel.com Change-Id: I6214fb83bccb19fe4edad65ce6b862815b8dcec6 --- M src/soc/amd/picasso/root_complex.c 1 file changed, 4 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/37/42837/1

diff --git a/src/soc/amd/picasso/root_complex.c b/src/soc/amd/picasso/root_complex.c index 4930a0e..807e205 100644 --- a/src/soc/amd/picasso/root_complex.c +++ b/src/soc/amd/picasso/root_complex.c @@ -134,8 +134,11 @@ static void root_complex_fill_ssdt(const struct device *device) { msr_t msr; + const char *scope = acpi_device_scope(device); + if (!scope) + return;

- acpigen_write_scope(acpi_device_scope(device)); + acpigen_write_scope(scope);

msr = rdmsr(TOP_MEM); acpigen_write_name_dword("TOM1", msr.lo);

Attachments:

attachment.htm (text/html — 2.8 KB)

Show replies by date

John Zhao (Code Review)

26 Jun 26 Jun

5:20 p.m.

Hello build bot (Jenkins), Paul Menzel,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/42837

to look at the new patch set (#2).

Change subject: soc/amd/picasso: Avoid NULL pointer dereference ......................................................................

soc/amd/picasso: Avoid NULL pointer dereference

Coverity detects dereferencing a pointer that might be "NULL" when calling acpigen_write_scope. Add sanity check for scope to prevent NULL pointer dereference.

Found-by: Coverity CID 1429980 TEST=None

Signed-off-by: John Zhao john.zhao@intel.com Change-Id: I6214fb83bccb19fe4edad65ce6b862815b8dcec6 --- M src/soc/amd/picasso/root_complex.c 1 file changed, 4 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/37/42837/2

Patrick Rudolph (Code Review)

29 Jun 29 Jun

6:02 a.m.

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42837 )

Change subject: soc/amd/picasso: Avoid NULL pointer dereference ......................................................................

Patch Set 2: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/42837 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6214fb83bccb19fe4edad65ce6b862815b8dcec6 Gerrit-Change-Number: 42837 Gerrit-PatchSet: 2 Gerrit-Owner: John Zhao john.zhao@intel.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Mon, 29 Jun 2020 06:02:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

John Zhao (Code Review)

5:20 p.m.

Hello build bot (Jenkins), Paul Menzel, Patrick Rudolph,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/42837

to look at the new patch set (#3).

Change subject: soc/amd/picasso: Avoid NULL pointer dereference ......................................................................

soc/amd/picasso: Avoid NULL pointer dereference

Coverity detects dereferencing a pointer that might be "NULL" when calling acpigen_write_scope. Add sanity check for scope to prevent NULL pointer dereference.

Found-by: Coverity CID 1429980 TEST=None

Signed-off-by: John Zhao john.zhao@intel.com Change-Id: I6214fb83bccb19fe4edad65ce6b862815b8dcec6 --- M src/soc/amd/picasso/root_complex.c 1 file changed, 5 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/37/42837/3

John Zhao (Code Review)

6 Jul 6 Jul

8:49 p.m.

Hello build bot (Jenkins), Paul Menzel, Patrick Rudolph,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/42837

to look at the new patch set (#4).

Change subject: soc/amd/picasso: Avoid NULL pointer dereference ......................................................................

soc/amd/picasso: Avoid NULL pointer dereference

Coverity detects dereferencing a pointer that might be "NULL" when calling acpigen_write_scope. Add sanity check for scope to prevent NULL pointer dereference.

Found-by: Coverity CID 1429980 TEST=None

Signed-off-by: John Zhao john.zhao@intel.com Change-Id: I6214fb83bccb19fe4edad65ce6b862815b8dcec6 --- M src/soc/amd/picasso/root_complex.c 1 file changed, 7 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/37/42837/4

Aaron Durbin (Code Review)

9:31 p.m.

Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42837 )

Change subject: soc/amd/picasso: Avoid NULL pointer dereference ......................................................................

Patch Set 4:

(1 comment)

https://review.coreboot.org/c/coreboot/+/42837/4/src/soc/amd/picasso/root_co... File src/soc/amd/picasso/root_complex.c:

https://review.coreboot.org/c/coreboot/+/42837/4/src/soc/amd/picasso/root_co... PS4, Line 146: if (!scope) { I really think these checks should be an assert(). It's not possible for device to be NULL.

-- To view, visit https://review.coreboot.org/c/coreboot/+/42837 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6214fb83bccb19fe4edad65ce6b862815b8dcec6 Gerrit-Change-Number: 42837 Gerrit-PatchSet: 4 Gerrit-Owner: John Zhao john.zhao@intel.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Aaron Durbin adurbin@chromium.org Gerrit-Comment-Date: Mon, 06 Jul 2020 21:31:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

John Zhao (Code Review)

9:51 p.m.

Hello build bot (Jenkins), Tim Wawrzynczak, Paul Menzel, Patrick Rudolph,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/42837

to look at the new patch set (#5).

Change subject: soc/amd/picasso: Avoid NULL pointer dereference ......................................................................

soc/amd/picasso: Avoid NULL pointer dereference

Coverity detects dereferencing a pointer that might be "NULL" when calling acpigen_write_scope. Add sanity check for scope to prevent NULL pointer dereference.

Found-by: Coverity CID 1429980 TEST=None

Signed-off-by: John Zhao john.zhao@intel.com Change-Id: I6214fb83bccb19fe4edad65ce6b862815b8dcec6 --- M src/soc/amd/picasso/root_complex.c 1 file changed, 4 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/37/42837/5

-- To view, visit https://review.coreboot.org/c/coreboot/+/42837 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6214fb83bccb19fe4edad65ce6b862815b8dcec6 Gerrit-Change-Number: 42837 Gerrit-PatchSet: 5 Gerrit-Owner: John Zhao john.zhao@intel.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Aaron Durbin adurbin@chromium.org Gerrit-MessageType: newpatchset

John Zhao (Code Review)

9:51 p.m.

John Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42837 )

Change subject: soc/amd/picasso: Avoid NULL pointer dereference ......................................................................

Patch Set 5:

(1 comment)

https://review.coreboot.org/c/coreboot/+/42837/4/src/soc/amd/picasso/root_co... File src/soc/amd/picasso/root_complex.c:

https://review.coreboot.org/c/coreboot/+/42837/4/src/soc/amd/picasso/root_co... PS4, Line 146: if (!scope) {

...

I really think these checks should be an assert(). It's not possible for device to be NULL.

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/42837 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6214fb83bccb19fe4edad65ce6b862815b8dcec6 Gerrit-Change-Number: 42837 Gerrit-PatchSet: 5 Gerrit-Owner: John Zhao john.zhao@intel.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Aaron Durbin adurbin@chromium.org Gerrit-Comment-Date: Mon, 06 Jul 2020 21:51:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Aaron Durbin adurbin@chromium.org Gerrit-MessageType: comment

Aaron Durbin (Code Review)

9:57 p.m.

Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42837 )

Change subject: soc/amd/picasso: Avoid NULL pointer dereference ......................................................................

Patch Set 5:

(1 comment)

https://review.coreboot.org/c/coreboot/+/42837/5/src/soc/amd/picasso/root_co... File src/soc/amd/picasso/root_complex.c:

https://review.coreboot.org/c/coreboot/+/42837/5/src/soc/amd/picasso/root_co... PS5, Line 139: if (!device) { I was hoping we could do the device check as an assert as well.

-- To view, visit https://review.coreboot.org/c/coreboot/+/42837 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6214fb83bccb19fe4edad65ce6b862815b8dcec6 Gerrit-Change-Number: 42837 Gerrit-PatchSet: 5 Gerrit-Owner: John Zhao john.zhao@intel.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Aaron Durbin adurbin@chromium.org Gerrit-Comment-Date: Mon, 06 Jul 2020 21:57:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

John Zhao (Code Review)

10:08 p.m.

Hello build bot (Jenkins), Tim Wawrzynczak, Paul Menzel, Patrick Rudolph,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/42837

to look at the new patch set (#6).

Change subject: soc/amd/picasso: Avoid NULL pointer dereference ......................................................................

soc/amd/picasso: Avoid NULL pointer dereference

Coverity detects dereferencing a pointer that might be "NULL" when calling acpigen_write_scope. Add sanity check for scope to prevent NULL pointer dereference.

Found-by: Coverity CID 1429980 TEST=None

Signed-off-by: John Zhao john.zhao@intel.com Change-Id: I6214fb83bccb19fe4edad65ce6b862815b8dcec6 --- M src/soc/amd/picasso/root_complex.c 1 file changed, 6 insertions(+), 6 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/37/42837/6

-- To view, visit https://review.coreboot.org/c/coreboot/+/42837 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6214fb83bccb19fe4edad65ce6b862815b8dcec6 Gerrit-Change-Number: 42837 Gerrit-PatchSet: 6 Gerrit-Owner: John Zhao john.zhao@intel.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Aaron Durbin adurbin@chromium.org Gerrit-MessageType: newpatchset

Aaron Durbin (Code Review)

10:08 p.m.

Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42837 )

Change subject: soc/amd/picasso: Avoid NULL pointer dereference ......................................................................

Patch Set 6:

(1 comment)

https://review.coreboot.org/c/coreboot/+/42837/6/src/soc/amd/picasso/root_co... File src/soc/amd/picasso/root_complex.c:

https://review.coreboot.org/c/coreboot/+/42837/6/src/soc/amd/picasso/root_co... PS6, Line 140: dev This would need to be 'device'

-- To view, visit https://review.coreboot.org/c/coreboot/+/42837 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6214fb83bccb19fe4edad65ce6b862815b8dcec6 Gerrit-Change-Number: 42837 Gerrit-PatchSet: 6 Gerrit-Owner: John Zhao john.zhao@intel.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Aaron Durbin adurbin@chromium.org Gerrit-Comment-Date: Mon, 06 Jul 2020 22:08:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

John Zhao (Code Review)

10:09 p.m.

John Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42837 )

Change subject: soc/amd/picasso: Avoid NULL pointer dereference ......................................................................

Patch Set 6:

(1 comment)

https://review.coreboot.org/c/coreboot/+/42837/6/src/soc/amd/picasso/root_co... File src/soc/amd/picasso/root_complex.c:

https://review.coreboot.org/c/coreboot/+/42837/6/src/soc/amd/picasso/root_co... PS6, Line 140: dev

...

This would need to be 'device'

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/42837 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6214fb83bccb19fe4edad65ce6b862815b8dcec6 Gerrit-Change-Number: 42837 Gerrit-PatchSet: 6 Gerrit-Owner: John Zhao john.zhao@intel.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Aaron Durbin adurbin@chromium.org Gerrit-Comment-Date: Mon, 06 Jul 2020 22:09:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Aaron Durbin adurbin@chromium.org Gerrit-MessageType: comment

John Zhao (Code Review)

10:11 p.m.

Hello build bot (Jenkins), Tim Wawrzynczak, Paul Menzel, Patrick Rudolph,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/42837

to look at the new patch set (#7).

Change subject: soc/amd/picasso: Avoid NULL pointer dereference ......................................................................

soc/amd/picasso: Avoid NULL pointer dereference

Coverity detects dereferencing a pointer that might be "NULL" when calling acpigen_write_scope. Add sanity check for scope to prevent NULL pointer dereference.

Found-by: Coverity CID 1429980 TEST=None

Signed-off-by: John Zhao john.zhao@intel.com Change-Id: I6214fb83bccb19fe4edad65ce6b862815b8dcec6 --- M src/soc/amd/picasso/root_complex.c 1 file changed, 6 insertions(+), 6 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/37/42837/7

-- To view, visit https://review.coreboot.org/c/coreboot/+/42837 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6214fb83bccb19fe4edad65ce6b862815b8dcec6 Gerrit-Change-Number: 42837 Gerrit-PatchSet: 7 Gerrit-Owner: John Zhao john.zhao@intel.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Aaron Durbin adurbin@chromium.org Gerrit-MessageType: newpatchset

Aaron Durbin (Code Review)

10:12 p.m.

Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42837 )

Change subject: soc/amd/picasso: Avoid NULL pointer dereference ......................................................................

Patch Set 7: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/42837 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6214fb83bccb19fe4edad65ce6b862815b8dcec6 Gerrit-Change-Number: 42837 Gerrit-PatchSet: 7 Gerrit-Owner: John Zhao john.zhao@intel.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Mon, 06 Jul 2020 22:12:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

John Zhao (Code Review)

10 Jul 10 Jul

5:33 p.m.

John Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42837 )

Change subject: soc/amd/picasso: Avoid NULL pointer dereference ......................................................................

Patch Set 7:

(1 comment)

https://review.coreboot.org/c/coreboot/+/42837/5/src/soc/amd/picasso/root_co... File src/soc/amd/picasso/root_complex.c:

https://review.coreboot.org/c/coreboot/+/42837/5/src/soc/amd/picasso/root_co... PS5, Line 139: if (!device) {

...

I was hoping we could do the device check as an assert as well.

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/42837 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6214fb83bccb19fe4edad65ce6b862815b8dcec6 Gerrit-Change-Number: 42837 Gerrit-PatchSet: 7 Gerrit-Owner: John Zhao john.zhao@intel.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Fri, 10 Jul 2020 17:33:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Aaron Durbin adurbin@chromium.org Gerrit-MessageType: comment

Aaron Durbin (Code Review)

5:33 p.m.

Aaron Durbin has submitted this change. ( https://review.coreboot.org/c/coreboot/+/42837 )

Change subject: soc/amd/picasso: Avoid NULL pointer dereference ......................................................................

soc/amd/picasso: Avoid NULL pointer dereference

Coverity detects dereferencing a pointer that might be "NULL" when calling acpigen_write_scope. Add sanity check for scope to prevent NULL pointer dereference.

Found-by: Coverity CID 1429980 TEST=None

Signed-off-by: John Zhao john.zhao@intel.com Change-Id: I6214fb83bccb19fe4edad65ce6b862815b8dcec6 Reviewed-on: https://review.coreboot.org/c/coreboot/+/42837 Reviewed-by: Aaron Durbin adurbin@chromium.org Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/soc/amd/picasso/root_complex.c 1 file changed, 6 insertions(+), 6 deletions(-)

Approvals: build bot (Jenkins): Verified Aaron Durbin: Looks good to me, approved

diff --git a/src/soc/amd/picasso/root_complex.c b/src/soc/amd/picasso/root_complex.c index 036ff00..1c06928 100644 --- a/src/soc/amd/picasso/root_complex.c +++ b/src/soc/amd/picasso/root_complex.c @@ -1,6 +1,7 @@ /* SPDX-License-Identifier: GPL-2.0-only */

#include <acpi/acpigen.h> +#include <assert.h> #include <cbmem.h> #include <console/console.h> #include <cpu/amd/msr.h> @@ -134,14 +135,13 @@ static void root_complex_fill_ssdt(const struct device *device) { msr_t msr; + const char *scope;

- if (!device) { - printk(BIOS_ERR, "%s: device is NULL! ACPI SSDT will be incomplete.\n", - __func__); - return; - } + assert(device);

- acpigen_write_scope(acpi_device_scope(device)); + scope = acpi_device_scope(device); + assert(scope); + acpigen_write_scope(scope);

msr = rdmsr(TOP_MEM); acpigen_write_name_dword("TOM1", msr.lo);

-- To view, visit https://review.coreboot.org/c/coreboot/+/42837 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I6214fb83bccb19fe4edad65ce6b862815b8dcec6 Gerrit-Change-Number: 42837 Gerrit-PatchSet: 8 Gerrit-Owner: John Zhao john.zhao@intel.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: merged

1409

days inactive

1423

days old

coreboot-gerrit@coreboot.org

15 comments

3 participants

tags (0)

participants (3)

Aaron Durbin (Code Review)
John Zhao (Code Review)
Patrick Rudolph (Code Review)