Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42837 )
Change subject: soc/amd/picasso: Avoid NULL pointer dereference
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42837/5/src/soc/amd/picasso/root_co...
File src/soc/amd/picasso/root_complex.c:
https://review.coreboot.org/c/coreboot/+/42837/5/src/soc/amd/picasso/root_co...
PS5, Line 139: if (!device) {
I was hoping we could do the device check as an assert as well.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42837
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6214fb83bccb19fe4edad65ce6b862815b8dcec6
Gerrit-Change-Number: 42837
Gerrit-PatchSet: 5
Gerrit-Owner: John Zhao
john.zhao@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Aaron Durbin
adurbin@chromium.org
Gerrit-Comment-Date: Mon, 06 Jul 2020 21:57:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment