Attention is currently required from: Jason Glenesk, Tim Van Patten.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74378 )
Change subject: vc/amd/fsp/phoenix/platform_descriptors: add PCIe gen 4 link speed
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
Oh, nice. I'm glad it was this easy. […]
this at least corresponds to what i saw in the reference code. not sure if any work is needed on the fsp side or if everything is already in place there. the reference code also sets in the pspp related port parameters in the equivalent of the port descriptor struct array, but i'd advise against enabling pspp too early; iirc on cezanne enabling pspp caused a bit of trouble at first, so it's not a too great idea to already enable pspp for bringup
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74378
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I74f0b79e336206113ade24a87cbd161a12967f56
Gerrit-Change-Number: 74378
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Jon Murphy
jpmurphy@google.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Tim Van Patten
timvp@google.com
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Tim Van Patten
timvp@google.com
Gerrit-Comment-Date: Thu, 13 Apr 2023 17:35:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Van Patten
timvp@google.com
Gerrit-MessageType: comment