[S] Change in coreboot[master]: src/commonlib/fsp_relocate.c: Fix cbfstool build on 32 bit host
Attention is currently required from: Martin L Roth, Paul Menzel, Ed Sharma, Angel Pons.
Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69682 )
Change subject: src/commonlib/fsp_relocate.c: Fix cbfstool build on 32 bit host ......................................................................
Patch Set 2:
(6 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/69682/comment/5bea5f51_ff5d4305 PS2, Line 7: src/
Remove.
Ack
https://review.coreboot.org/c/coreboot/+/69682/comment/c0694dc0_0ece071c PS2, Line 7: 32 bit
I’d spell it 32-bit.
Ack
https://review.coreboot.org/c/coreboot/+/69682/comment/541369c8_5746392e PS2, Line 10: build
built
Ack
https://review.coreboot.org/c/coreboot/+/69682/comment/51560f33_01acbffd PS2, Line 17:
The macros in `src/include/inttypes. […]
Thanks for the pointer Paul. It is indeed that these formatter defines are available on the host as well and are defined correctly to distinguish between 32 and 64 bit hosts. So using PRIxPTR _is_ helpful here. Will update the patch accordingly.
https://review.coreboot.org/c/coreboot/+/69682/comment/ed286084_9667b5e2 PS2, Line 19:
Maybe mention the compiler you used.
With the usage of PRIxPTR it is now transparent and independent of the compiler.
File src/commonlib/fsp_relocate.c:
https://review.coreboot.org/c/coreboot/+/69682/comment/3c2a2f23_6775ae22 PS2, Line 222: printk(FSP_DBG_LVL, "relocating PE32 image at addr - 0x%p\n", (void *) new_addr);
No space between cast and variable?
Done
-
Werner Zeh (Code Review)