Change in ...coreboot[master]: util/xcompile/xcompile: apply -march to clang as well as gcc
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32923 )
Change subject: util/xcompile/xcompile: apply -march to clang as well as gcc ......................................................................
Patch Set 1: Code-Review+1
(2 comments)
Maybe we could get rid of the "config SSE" and just unconditionally set CR4 SSE nowadays?
Still, -no-sse should ne implied or explicit for AMD ASEG SMM implementation and possibly amdfam10-15 raminit that appear to lack the clobbers for xmmX in its inline assembly. Could become an issue with the x86_64 build.
Those can be followup fixes.
https://review.coreboot.org/#/c/32923/1/util/xcompile/xcompile File util/xcompile/xcompile:
https://review.coreboot.org/#/c/32923/1/util/xcompile/xcompile@257 PS1, Line 257: # flags. Note that this doesn't prevent a project using Seems like a stale comment after CB:20244, SMM modules tolerate SSE instructions nowadays.
https://review.coreboot.org/#/c/32923/1/util/xcompile/xcompile@264 PS1, Line 264: CFLAGS_${TARCH} += -march=nocona -malign-data=abi This enables SSE instructions, while CR4 SSE enable bit might not be set.
-
Kyösti Mälkki (Code Review)