Attention is currently required from: Robert Zieba, Bao Zheng, Jon Murphy, Rob Barnes, Karthik Ramasubramanian, Felix Held.
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/66554 )
Change subject: util/amdfwtool/amdfwread: Handle recovery A/B layout
......................................................................
Patch Set 14:
(1 comment)
File util/amdfwtool/amdfwread.c:
https://review.coreboot.org/c/coreboot/+/66554/comment/2936d954_fe812aea
PS14, Line 157: break
This is the break for the case statement so that we dont fallthrough to the next case. […]
lol thanks for pointing that out :)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/66554
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6576eaebc611ab338885aed2ee087bf85da3ca15
Gerrit-Change-Number: 66554
Gerrit-PatchSet: 14
Gerrit-Owner: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Bao Zheng
fishbaozi@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jon Murphy
jpmurphy@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Rob Barnes
robbarnes@google.com
Gerrit-Reviewer: Robert Zieba
robertzieba@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Robert Zieba
robertzieba@google.com
Gerrit-Attention: Bao Zheng
fishbaozi@gmail.com
Gerrit-Attention: Jon Murphy
jpmurphy@google.com
Gerrit-Attention: Rob Barnes
robbarnes@google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Thu, 20 Oct 2022 18:31:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com
Gerrit-MessageType: comment