Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36275 )
Change subject: arch/arm64: Pass cbmem_top to ramstage via calling argument ......................................................................
Patch Set 20:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36275/20/src/arch/arm64/Kconfig File src/arch/arm64/Kconfig:
https://review.coreboot.org/c/coreboot/+/36275/20/src/arch/arm64/Kconfig@20 PS20, Line 20: select RAMSTAGE_CBMEM_TOP_ARG if !SOC_NVIDIA_TEGRA210
Is this the only chipset that cannot switch to the new scheme? Otherwise (if we need to have excepti […]
Yeah, hmm, looks like it is.
Another really simple solution would be to just call
_cbmem_top_ptr = cbmem_top_chipset();
near the end of ramstage_entry(). That's not parameter passing, but the platform doesn't really need that to work because its cbmem_top_chipset() works fine in both stages.
-
Julius Werner (Code Review)