Attention is currently required from: Ravi Kumar Bokka, Paul Menzel, Julius Werner. Sudheer Amrabadi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63085 )
Change subject: sc7280: Improve performance by removing delays in cpucp init ......................................................................
Patch Set 16:
(5 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/63085/comment/4482f2d2_cc817691 PS3, Line 7: Performance improvement by removing delays in cpucp init
Please add a prefix, and make it a statement by adding a verb (in imperative mood).
Ack
https://review.coreboot.org/c/coreboot/+/63085/comment/8960d38a_adc77ec4 PS3, Line 12: TEST=Validated on qualcomm sc7280 development board
Please list old and new timestamps.
Ack
Commit Message:
https://review.coreboot.org/c/coreboot/+/63085/comment/f16da37a_14ea1dd7 PS6, Line 7: sc7280: Performance improvement by removing delays in cpucp init
Please make it a statement: […]
Ack
File src/mainboard/google/herobrine/romstage.c:
https://review.coreboot.org/c/coreboot/+/63085/comment/639edd5c_072ce4a6 PS3, Line 19: void cpucp_prepare(void)
You should keep this function in SoC code and just link that file into romstage, then call it from h […]
hi julius can I move this to src/soc/qualcomm/sc780/soc.c ?
File src/soc/qualcomm/sc7280/cpucp_load_reset.c:
https://review.coreboot.org/c/coreboot/+/63085/comment/7fa85b6c_c74ecc3c PS3, Line 12:
Should be no more than one blank line here.
Ack