Attention is currently required from: Ravi Kumar Bokka, Paul Menzel, Julius Werner.

View Change

5 comments:

• Commit Message:

  • Patch Set #3, Line 7: Performance improvement by removing delays in cpucp init

    Please add a prefix, and make it a statement by adding a verb (in imperative mood).

    Ack

  • Patch Set #3, Line 12: TEST=Validated on qualcomm sc7280 development board

    Please list old and new timestamps.

    Ack

• Commit Message:

  • Patch Set #6, Line 7: sc7280: Performance improvement by removing delays in cpucp init

    Please make it a statement: […]

    Ack

• File src/mainboard/google/herobrine/romstage.c:

  • Patch Set #3, Line 19: void cpucp_prepare(void)

    You should keep this function in SoC code and just link that file into romstage, then call it from h […]

    hi julius can I move this to src/soc/qualcomm/sc780/soc.c ?

• File src/soc/qualcomm/sc7280/cpucp_load_reset.c:

  • Patch Set #3, Line 12:

    Should be no more than one blank line here.

    Ack

To view, visit change 63085. To unsubscribe, or for help writing mail filters, visit settings.