Change in coreboot[master]: src: introduce MP_TABLE_FILE Kconfig symbol

[Felix Held (Code Review)]

Felix Held has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/42603 )

Change subject: src: introduce MP_TABLE_FILE Kconfig symbol
......................................................................

src: introduce MP_TABLE_FILE Kconfig symbol

This new symbol allows overriding the default location of the mptable.c
file to allow having different mptable.c files in board variant sub-
directories.

Change-Id: Iee2f72f8729a3d80afed959fd4354a6e6316bba1
Signed-off-by: Felix Held 
---
M src/Kconfig
M src/arch/x86/Makefile.inc
2 files changed, 8 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/03/42603/1

diff --git a/src/Kconfig b/src/Kconfig
index f718844..c754dde 100644
--- a/src/Kconfig
+++ b/src/Kconfig
@@ -647,6 +647,13 @@
      Whether or not the MP table is actually generated by coreboot
      is configurable by the user via GENERATE_MP_TABLE.

+config MP_TABLE_FILE
+	string
+	default "src/mainboard/$(CONFIG_MAINBOARD_DIR)/mptable.c"
+	help
+	  This symbol allows variants to provide an mptable.c file in a
+	  different location than right in the mainboard folder.
+
 config HAVE_PIRQ_TABLE
    bool
    help
diff --git a/src/arch/x86/Makefile.inc b/src/arch/x86/Makefile.inc
index 6297384..b59c34f 100644
--- a/src/arch/x86/Makefile.inc
+++ b/src/arch/x86/Makefile.inc
@@ -282,7 +282,7 @@
 ramstage-srcs += $(wildcard src/mainboard/$(MAINBOARDDIR)/mainboard.c)
 ifeq ($(CONFIG_GENERATE_MP_TABLE),y)
 ifneq ($(wildcard src/mainboard/$(MAINBOARDDIR)/mptable.c),)
-ramstage-srcs += src/mainboard/$(MAINBOARDDIR)/mptable.c
+ramstage-srcs += $(MP_TABLE_FILE)
 endif
 endif
 ifeq ($(CONFIG_GENERATE_PIRQ_TABLE),y)

[Julius Werner (Code Review)]

Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42603 )

Change subject: src: introduce MP_TABLE_FILE Kconfig symbol
......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/42603/1/src/Kconfig 
File src/Kconfig:

https://review.coreboot.org/c/coreboot/+/42603/1/src/Kconfig@650 
PS1, Line 650: config MP_TABLE_FILE
Can we move this and HAVE_MP_TABLE into src/arch/x86/Kconfig while we're here?

[Felix Held (Code Review)]

Felix Held has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/42603 )

Change subject: src: introduce MP_TABLE_FILE Kconfig symbol
......................................................................

Abandoned

found an easier workaround for variants of the one board needing it that doesn't need an extra Kconfig variable