Attention is currently required from: Jérémy Compostella, Karthik Ramasubramanian.
Subrata Banik has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/86225?usp=email )
Change subject: vc/google/chromeos: Add low battery indicator screen ......................................................................
Patch Set 2:
(1 comment)
File src/vendorcode/google/chromeos/Kconfig:
https://review.coreboot.org/c/coreboot/+/86225/comment/80cb5c11_e3615233?usp... : PS1, Line 128: Don't select if not sure.
Is this a useful statement ?
I'm afraid we might not enable this feature (early battery indicator due to eSOL dependency using uGOP) for PTL in day-1 of `CHROMEOS_LOW_BATTERY_INDICATOR_SCREEN` Kconfig being enabled for GFX mode rendering therefore, wanted to clarify that only choose the `CHROMEOS_LOW_BATTERY_INDICATOR_SCREEN_EARLY` Kconfig if ur platform has support for (may be like Brox).