[XL] Change in coreboot[main]: mb/dell: OptiPlex 3050 Micro port (Intel KabyLake)

[Máté Kukri (Code Review)]

Attention is currently required from: Angel Pons, Elyes Haouas, Felix Singer, Paul Menzel.

Máté Kukri has posted comments on this change by Máté Kukri. ( https://review.coreboot.org/c/coreboot/+/82053?usp=email )

Change subject: mb/dell: OptiPlex 3050 Micro port (Intel KabyLake)
......................................................................

Patch Set 16:

(11 comments)

Commit Message:

https://review.coreboot.org/c/coreboot/+/82053/comment/b9c626c6_6042bfdd?usp... :
PS15, Line 7: OptiPlex 3050 Micro port
> Please make it a statement. Maybe: […]

Done

https://review.coreboot.org/c/coreboot/+/82053/comment/04447c35_98e3e067?usp... :
PS15, Line 9: - Boots Linux
> It’d be great if you elaborate, what payload and what Linux version.

Done

File src/mainboard/dell/optiplex_3050/Kconfig:

https://review.coreboot.org/c/coreboot/+/82053/comment/6b608337_ea6f2795?usp... :
PS11, Line 12: 	# select INTEL_GMA_HAVE_VBT
> Yes

Done

File src/mainboard/dell/optiplex_3050/devicetree.cb:

https://review.coreboot.org/c/coreboot/+/82053/comment/86b2c2cc_bc2805a3?usp... :
PS14, Line 9: 	device cpu_cluster 0 on end
> This is not needed as well, since it's in chipset devicetree.

Done

https://review.coreboot.org/c/coreboot/+/82053/comment/51e9fc62_a937c927?usp... :
PS14, Line 18: OC0
> Yeah it is definitely wrong, I still need to fix the USB ports, that's just bad copypasta

I've removed the bad OCs now. proper part map is still a TODO but wrong code is worse imo.

https://review.coreboot.org/c/coreboot/+/82053/comment/6a6b1774_fee9029e?usp... :
PS14, Line 55: 		device ref pcie_rp21 on
> While on it, please add SMBIOS slot description.

Added the comment about the M.2 port

File src/mainboard/dell/optiplex_3050/ramstage.c:

https://review.coreboot.org/c/coreboot/+/82053/comment/180538e0_1914e105?usp... :
PS14, Line 11: static void init_mainboard(void *chip_info)
             : {
             : }
             : 
             : struct chip_operations mainboard_ops = {
             : 	.init = init_mainboard,
             : };
> It would be better to configure GPIOs in init_mainboard, since it runs after FSP and it might do unw […]

Ack. Other boards seems to do it before FSP and it works on this.

File src/mainboard/dell/optiplex_3050/ramstage.c:

https://review.coreboot.org/c/coreboot/+/82053/comment/1c7a2085_8856f559?usp... :
PS15, Line 504: 	if (get_core_cnt() > 2) {
> The core_cnt variable exist to not have to call this twice... […]

Done

File src/mainboard/dell/optiplex_3050/romstage.c:

https://review.coreboot.org/c/coreboot/+/82053/comment/676318ac_9aaa8f5e?usp... :
PS11, Line 24: 	 * FIXME: do we need this? */
> I'll test if this can be removed when i add audio

Removed it.

File src/mainboard/dell/optiplex_3050/romstage.c:

https://review.coreboot.org/c/coreboot/+/82053/comment/be21f736_9c1d9f72?usp... :
PS14, Line 3: #include <assert.h>
> maybe not used

Done

https://review.coreboot.org/c/coreboot/+/82053/comment/8c9fee4b_1e314371?usp... :
PS14, Line 8: include <cbfs.h>
> maybe not used

Done