Attention is currently required from: Ren Kuo.
Paul Menzel has posted comments on this change by Ren Kuo. ( https://review.coreboot.org/c/coreboot/+/84545?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: mb/google/brox/jubilant: Modify FP IRQ pin on disable pads ......................................................................
Patch Set 6:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/84545/comment/a77bb0f5_099a81ec?usp... : PS6, Line 7: Modify FP IRQ pin on disable pads Update FP IRQ pin to GPP_D13 in fp_disable_pads
https://review.coreboot.org/c/coreboot/+/84545/comment/9d6b039b_8e0126b5?usp... : PS6, Line 9: In previous CB:84124 Please also use git hashes, as that is what git commands operates with:
Commit 8cfe1b3302ff (mb/google/brox/jubilant: Modify FP IRQ pin to GPP_D13), CB:84124, changes the fingerprint IRQ pin from GPP_F15 to GPP_D13, but forgot to update the pin in the array `fp_disable_pads`. …