Change in coreboot[master]: Revert "mb/google/zork: Modify USB 2.0 PHY parameters for Woomax"
Hello build bot (Jenkins), Martin Roth, Furquan Shaikh, Kane Chen, Aaron Durbin,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/45005
to review the following change.
Change subject: Revert "mb/google/zork: Modify USB 2.0 PHY parameters for Woomax" ......................................................................
Revert "mb/google/zork: Modify USB 2.0 PHY parameters for Woomax"
This reverts commit 4dcccc83656cfe98af93ef47e6fbc269f16c900d.
Reason for revert: Servo_v4 USB hub fails with this change: b/170879690
Change-Id: I35b60fdb962553ecfa289b828ae5d809b4d621c6 --- M src/mainboard/google/zork/variants/woomax/overridetree.cb 1 file changed, 0 insertions(+), 24 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/45005/1
diff --git a/src/mainboard/google/zork/variants/woomax/overridetree.cb b/src/mainboard/google/zork/variants/woomax/overridetree.cb index d1c5507..de39891 100644 --- a/src/mainboard/google/zork/variants/woomax/overridetree.cb +++ b/src/mainboard/google/zork/variants/woomax/overridetree.cb @@ -22,30 +22,6 @@ register "telemetry_vddcr_soc_offset" = "0"
# End : OPN Performance Configuration - #USB 2.0 strength - register "usb_2_port_tune_params[0]" = "{ - .com_pds_tune = 0x03, - .sq_rx_tune = 0x3, - .tx_fsls_tune = 0x3, - .tx_pre_emp_amp_tune = 0x03, - .tx_pre_emp_pulse_tune = 0x0, - .tx_rise_tune = 0x1, - .rx_vref_tune = 0xf, - .tx_hsxv_tune = 0x3, - .tx_res_tune = 0x01, - }" - - register "usb_2_port_tune_params[3]" = "{ - .com_pds_tune = 0x03, - .sq_rx_tune = 0x3, - .tx_fsls_tune = 0x3, - .tx_pre_emp_amp_tune = 0x03, - .tx_pre_emp_pulse_tune = 0x0, - .tx_rise_tune = 0x1, - .rx_vref_tune = 0xf, - .tx_hsxv_tune = 0x3, - .tx_res_tune = 0x01, - }"
# USB OC pin mapping register "usb_port_overcurrent_pin[2]" = "USB_OC_NONE" # NC
Hello build bot (Jenkins), Martin Roth, Furquan Shaikh, Kane Chen, Aaron Durbin,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/45005
to look at the new patch set (#2).
Change subject: Revert "mb/google/zork: Modify USB 2.0 PHY parameters for Woomax" ......................................................................
Revert "mb/google/zork: Modify USB 2.0 PHY parameters for Woomax"
This reverts commit 4dcccc83656cfe98af93ef47e6fbc269f16c900d.
Reason for revert: Servo_v4 USB hub fails with this change: b/170879690
BUG=b:170879690 TEST=Servo_v4 USB hub works after revert BRANCH=zork
Change-Id: I35b60fdb962553ecfa289b828ae5d809b4d621c6 --- M src/mainboard/google/zork/variants/woomax/overridetree.cb 1 file changed, 0 insertions(+), 24 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/45005/2
Hello build bot (Jenkins), Martin Roth, Furquan Shaikh, Kane Chen, Aaron Durbin,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/45005
to look at the new patch set (#3).
Change subject: Revert "mb/google/zork: Modify USB 2.0 PHY parameters for Woomax" ......................................................................
Revert "mb/google/zork: Modify USB 2.0 PHY parameters for Woomax"
This reverts commit 4dcccc83656cfe98af93ef47e6fbc269f16c900d.
Reason for revert: Servo_v4 USB hub fails with this change: b/170879690
BUG=b:170879690 TEST=Servo_v4 USB hub works after revert BRANCH=zork
Change-Id: I35b60fdb962553ecfa289b828ae5d809b4d621c6 Signed-off-by: Rob Barnes robbarnes@google.com --- M src/mainboard/google/zork/variants/woomax/overridetree.cb 1 file changed, 0 insertions(+), 24 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/45005/3
Rob Barnes has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/45005 )
Change subject: Revert "mb/google/zork: Modify USB 2.0 PHY parameters for Woomax" ......................................................................
Abandoned
Fix in https://review.coreboot.org/c/coreboot/+/46601
-
Rob Barnes (Code Review)