Attention is currently required from: Bill XIE, Jérémy Compostella.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78906?usp=email )
Change subject: drivers/pc80/rtc/option.c: Reset only CMOS range covered by checksum ......................................................................
Patch Set 4: Code-Review+1
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/78906/comment/a6c0b8ed_869bbcd0 : PS4, Line 11: , I would remove this comma. It separates things too much in an already loooong sentence.
Patchset:
PS4: I agree to the patch, just want to mention that this will most likely change behavior in unexpected cases. IIRC, we have some `cmos.layout` files that define things outside the checksummed range. Without looking closer, it's hard to say if these should be cleared or not. And then there are also cases when things aren't declared at all.
But we could argue that they aren't cleared either with the option-table support disabled. Alas, behavior is vaguely defined in this area of coreboot.