Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33023
Change subject: soc/intel/common/cse: Declare g_cse statically ......................................................................
soc/intel/common/cse: Declare g_cse statically
Change-Id: I91b6ce3b52d987e2fc0f79e550fda2891502bfe8 Signed-off-by: Arthur Heymans arthur@aheymans.xyz --- M src/soc/intel/common/block/cse/cse.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/23/33023/1
diff --git a/src/soc/intel/common/block/cse/cse.c b/src/soc/intel/common/block/cse/cse.c index 302e6de..e4fc6e4 100644 --- a/src/soc/intel/common/block/cse/cse.c +++ b/src/soc/intel/common/block/cse/cse.c @@ -69,7 +69,7 @@ #define MEI_HDR_CSE_ADDR (((1 << 8) - 1) << MEI_HDR_CSE_ADDR_START)
-struct cse_device { +static struct cse_device { uintptr_t sec_bar; } g_cse CAR_GLOBAL;
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33023 )
Change subject: soc/intel/common/cse: Declare g_cse statically ......................................................................
Patch Set 1: Code-Review+2
Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/33023 )
Change subject: soc/intel/common/cse: Declare g_cse statically ......................................................................
soc/intel/common/cse: Declare g_cse statically
Change-Id: I91b6ce3b52d987e2fc0f79e550fda2891502bfe8 Signed-off-by: Arthur Heymans arthur@aheymans.xyz Reviewed-on: https://review.coreboot.org/c/coreboot/+/33023 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Furquan Shaikh furquan@google.com --- M src/soc/intel/common/block/cse/cse.c 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Furquan Shaikh: Looks good to me, approved
diff --git a/src/soc/intel/common/block/cse/cse.c b/src/soc/intel/common/block/cse/cse.c index 302e6de..e4fc6e4 100644 --- a/src/soc/intel/common/block/cse/cse.c +++ b/src/soc/intel/common/block/cse/cse.c @@ -69,7 +69,7 @@ #define MEI_HDR_CSE_ADDR (((1 << 8) - 1) << MEI_HDR_CSE_ADDR_START)
-struct cse_device { +static struct cse_device { uintptr_t sec_bar; } g_cse CAR_GLOBAL;