Attention is currently required from: Andrey Petrov, Arthur Heymans, Julius Werner, Karthik Ramasubramanian, Nick Vaccaro, Subrata Banik.
Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/77796?usp=email )
Change subject: {commonlib, libpayload}: Add "is_external display" in coreboot table
......................................................................
Patch Set 4:
(2 comments)
File src/drivers/intel/fsp2_0/Kconfig:
https://review.coreboot.org/c/coreboot/+/77796/comment/8a916b4c_f64b7433 :
PS4, Line 447: config REPORT_EXTERNAL_DISPLAY_AT_PREBOOT
Is this used anywhere?
File src/drivers/intel/fsp2_0/include/fsp/graphics.h:
https://review.coreboot.org/c/coreboot/+/77796/comment/a405d2bf_6b7f2750 :
PS4, Line 25: int soc_report_external_display(void);
If it's declared here (only for intel fsp), then the function name should have the `fsp_` prefix. Otherwise, this should be declared in a general header file (shared for all platforms).
--
To view, visit
https://review.coreboot.org/c/coreboot/+/77796?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I0fa7eee4c5a50371a7a66c6ca1ac2c7d046d010b
Gerrit-Change-Number: 77796
Gerrit-PatchSet: 4
Gerrit-Owner: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Tue, 03 Oct 2023 09:22:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment