Kevin Chiu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/46537 )
Change subject: mb/google/zork: update USB 2.0 controller Lane Parameter for morphius ......................................................................
mb/google/zork: update USB 2.0 controller Lane Parameter for morphius
Enhance USB 2.0 HS DC Voltage Level
BUG=b:162614573 BRANCH=zork TEST=emerge-zork coreboot
Signed-off-by: Kevin Chiu kevin.chiu@quantatw.com Change-Id: I278cc0aaddbc9fce595bf57ca69ee8abfc9f5659 --- M src/mainboard/google/zork/variants/morphius/overridetree.cb 1 file changed, 13 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/37/46537/1
diff --git a/src/mainboard/google/zork/variants/morphius/overridetree.cb b/src/mainboard/google/zork/variants/morphius/overridetree.cb index ecadb07..62b08fb 100644 --- a/src/mainboard/google/zork/variants/morphius/overridetree.cb +++ b/src/mainboard/google/zork/variants/morphius/overridetree.cb @@ -35,6 +35,19 @@ .ports.xhci0_port2 = 1, /* Left USB3A port 2 */ }"
+ #USB 2.0 strength + register "usb_2_port_tune_params[3]" = "{ + .com_pds_tune = 0x03, + .sq_rx_tune = 0x3, + .tx_fsls_tune = 0x3, + .tx_pre_emp_amp_tune = 0x03, + .tx_pre_emp_pulse_tune = 0x0, + .tx_rise_tune = 0x1, + .rx_vref_tune = 0xf, + .tx_hsxv_tune = 0x3, + .tx_res_tune = 0x01, + }" + # Enable I2C2 for trackpad, touchscreen, pen at 400kHz register "i2c[2]" = "{ .speed = I2C_SPEED_FAST,
Kevin Chiu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46537 )
Change subject: mb/google/zork: update USB 2.0 controller Lane Parameter for morphius ......................................................................
Patch Set 1: Code-Review-1
it looks like "TXVREFTUNE0" over 0x7 will cause USB lost.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46537 )
Change subject: mb/google/zork: update USB 2.0 controller Lane Parameter for morphius ......................................................................
Patch Set 1:
(3 comments)
https://review.coreboot.org/c/coreboot/+/46537/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/46537/1//COMMIT_MSG@9 PS1, Line 9: Enhance USB 2.0 HS DC Voltage Level What are the default values, and where did you get the new values from?
https://review.coreboot.org/c/coreboot/+/46537/1//COMMIT_MSG@13 PS1, Line 13: TEST=emerge-zork coreboot Tested how?
https://review.coreboot.org/c/coreboot/+/46537/1/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/morphius/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/46537/1/src/mainboard/google/zork/v... PS1, Line 38: #USB 2.0 strength Please add a space after the #.
Hello build bot (Jenkins), Martin Roth, Furquan Shaikh, Patrick Georgi, Bhanu Prakash Maiya, Keith Tzeng, Rob Barnes, Eric Peers, Aaron Durbin,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/46537
to look at the new patch set (#2).
Change subject: mb/google/zork: update USB 2.0 controller Lane Parameter for morphius ......................................................................
mb/google/zork: update USB 2.0 controller Lane Parameter for morphius
Enhance USB 2.0 SI by increasing the level of "HS DC Voltage Level" and "Disconnect Threshold Adjustment"
BUG=b:162614573 BRANCH=zork TEST=emerge-zork coreboot
Signed-off-by: Kevin Chiu kevin.chiu@quantatw.com Change-Id: I278cc0aaddbc9fce595bf57ca69ee8abfc9f5659 --- M src/mainboard/google/zork/variants/morphius/overridetree.cb 1 file changed, 13 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/37/46537/2
Rob Barnes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46537 )
Change subject: mb/google/zork: update USB 2.0 controller Lane Parameter for morphius ......................................................................
Patch Set 2: Code-Review+1
Hello build bot (Jenkins), Martin Roth, Furquan Shaikh, Patrick Georgi, Bhanu Prakash Maiya, Keith Tzeng, Rob Barnes, Eric Peers, Aaron Durbin,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/46537
to look at the new patch set (#3).
Change subject: mb/google/zork: update USB 2.0 controller Lane Parameter for morphius ......................................................................
mb/google/zork: update USB 2.0 controller Lane Parameter for morphius
Enhance USB 2.0 SI by increasing the level of "HS DC Voltage Level" and "Disconnect Threshold Adjustment". COMPDISTUNE0: 0x3->0x7 TXVREFTUNE0: 0x6->0xf
BUG=b:162614573 BRANCH=zork TEST=emerge-zork coreboot
Signed-off-by: Kevin Chiu kevin.chiu@quantatw.com Change-Id: I278cc0aaddbc9fce595bf57ca69ee8abfc9f5659 --- M src/mainboard/google/zork/variants/morphius/overridetree.cb 1 file changed, 13 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/37/46537/3
Hello build bot (Jenkins), Martin Roth, Furquan Shaikh, Patrick Georgi, Bhanu Prakash Maiya, Keith Tzeng, Rob Barnes, Eric Peers, Aaron Durbin,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/46537
to look at the new patch set (#4).
Change subject: mb/google/zork: update USB 2.0 controller Lane Parameter for morphius ......................................................................
mb/google/zork: update USB 2.0 controller Lane Parameter for morphius
Enhance USB 2.0 SI by increasing the level of "HS DC Voltage Level" and "Disconnect Threshold Adjustment". COMPDISTUNE0: 0x3->0x7 TXVREFTUNE0: 0x6->0xf
BUG=b:162614573 BRANCH=zork TEST=1. emerge-zork coreboot 2. check U2 registers are set correctly 3. test with servo v4 type-c, it's working expectedly.
Signed-off-by: Kevin Chiu kevin.chiu@quantatw.com Change-Id: I278cc0aaddbc9fce595bf57ca69ee8abfc9f5659 --- M src/mainboard/google/zork/variants/morphius/overridetree.cb 1 file changed, 13 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/37/46537/4
Kevin Chiu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46537 )
Change subject: mb/google/zork: update USB 2.0 controller Lane Parameter for morphius ......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/46537/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/46537/1//COMMIT_MSG@9 PS1, Line 9: Enhance USB 2.0 HS DC Voltage Level
What are the default values, and where did you get the new values from?
Done
https://review.coreboot.org/c/coreboot/+/46537/1//COMMIT_MSG@13 PS1, Line 13: TEST=emerge-zork coreboot
Tested how?
Done
Hello build bot (Jenkins), Martin Roth, Furquan Shaikh, Patrick Georgi, Bhanu Prakash Maiya, Keith Tzeng, Rob Barnes, Eric Peers, Aaron Durbin,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/46537
to look at the new patch set (#5).
Change subject: mb/google/zork: update USB 2.0 controller Lane Parameter for morphius ......................................................................
mb/google/zork: update USB 2.0 controller Lane Parameter for morphius
Enhance USB 2.0 SI by increasing the level of "HS DC Voltage Level" and "Disconnect Threshold Adjustment". COMPDISTUNE0: 0x3->0x7 TXVREFTUNE0: 0x6->0xf
BUG=b:162614573 BRANCH=zork TEST=1. emerge-zork coreboot 2. check U2 registers are set correctly 3. test with servo v4 type-c, it's working expectedly.
Signed-off-by: Kevin Chiu kevin.chiu@quantatw.com Change-Id: I278cc0aaddbc9fce595bf57ca69ee8abfc9f5659 --- M src/mainboard/google/zork/variants/morphius/overridetree.cb 1 file changed, 13 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/37/46537/5
Kevin Chiu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46537 )
Change subject: mb/google/zork: update USB 2.0 controller Lane Parameter for morphius ......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46537/1/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/morphius/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/46537/1/src/mainboard/google/zork/v... PS1, Line 38: #USB 2.0 strength
Please add a space after the #.
Done
Hello build bot (Jenkins), Martin Roth, Furquan Shaikh, Patrick Georgi, Bhanu Prakash Maiya, Keith Tzeng, Rob Barnes, Eric Peers, Aaron Durbin,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/46537
to look at the new patch set (#6).
Change subject: mb/google/zork: update USB 2.0 controller Lane Parameter for morphius ......................................................................
mb/google/zork: update USB 2.0 controller Lane Parameter for morphius
Enhance USB 2.0 SI by increasing the level of "HS DC Voltage Level" and "Disconnect Threshold Adjustment". COMPDISTUNE0: 0x3->0x7 TXVREFTUNE0: 0x6->0xf
BUG=b:162614573 BRANCH=zork TEST=1. emerge-zork coreboot 2. check U2 registers are set correctly 3. test with servo v4 type-c, it's working expectedly. 4. U2 SI pass
Signed-off-by: Kevin Chiu kevin.chiu@quantatw.com Change-Id: I278cc0aaddbc9fce595bf57ca69ee8abfc9f5659 --- M src/mainboard/google/zork/variants/morphius/overridetree.cb 1 file changed, 13 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/37/46537/6
Keith Tzeng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46537 )
Change subject: mb/google/zork: update USB 2.0 controller Lane Parameter for morphius ......................................................................
Patch Set 6:
Please help review this, thanks.
Rob Barnes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46537 )
Change subject: mb/google/zork: update USB 2.0 controller Lane Parameter for morphius ......................................................................
Patch Set 6: Code-Review+1
Kevin Chiu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46537 )
Change subject: mb/google/zork: update USB 2.0 controller Lane Parameter for morphius ......................................................................
Patch Set 6:
Hi reviewers, U2 SI measurement was passed with this change, please kindly help review it. thank you!
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46537 )
Change subject: mb/google/zork: update USB 2.0 controller Lane Parameter for morphius ......................................................................
Patch Set 6: Code-Review+2
I can't test this on the hardware, but since it has already passed the signal integrity test, I'll just merge it
Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/46537 )
Change subject: mb/google/zork: update USB 2.0 controller Lane Parameter for morphius ......................................................................
mb/google/zork: update USB 2.0 controller Lane Parameter for morphius
Enhance USB 2.0 SI by increasing the level of "HS DC Voltage Level" and "Disconnect Threshold Adjustment". COMPDISTUNE0: 0x3->0x7 TXVREFTUNE0: 0x6->0xf
BUG=b:162614573 BRANCH=zork TEST=1. emerge-zork coreboot 2. check U2 registers are set correctly 3. test with servo v4 type-c, it's working expectedly. 4. U2 SI pass
Signed-off-by: Kevin Chiu kevin.chiu@quantatw.com Change-Id: I278cc0aaddbc9fce595bf57ca69ee8abfc9f5659 Reviewed-on: https://review.coreboot.org/c/coreboot/+/46537 Reviewed-by: Rob Barnes robbarnes@google.com Reviewed-by: Felix Held felix-coreboot@felixheld.de Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/zork/variants/morphius/overridetree.cb 1 file changed, 13 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Felix Held: Looks good to me, approved Rob Barnes: Looks good to me, but someone else must approve
diff --git a/src/mainboard/google/zork/variants/morphius/overridetree.cb b/src/mainboard/google/zork/variants/morphius/overridetree.cb index ecadb07..66b371b 100644 --- a/src/mainboard/google/zork/variants/morphius/overridetree.cb +++ b/src/mainboard/google/zork/variants/morphius/overridetree.cb @@ -35,6 +35,19 @@ .ports.xhci0_port2 = 1, /* Left USB3A port 2 */ }"
+ # USB 2.0 strength + register "usb_2_port_tune_params[3]" = "{ + .com_pds_tune = 0x07, + .sq_rx_tune = 0x3, + .tx_fsls_tune = 0x3, + .tx_pre_emp_amp_tune = 0x03, + .tx_pre_emp_pulse_tune = 0x0, + .tx_rise_tune = 0x1, + .rx_vref_tune = 0xf, + .tx_hsxv_tune = 0x3, + .tx_res_tune = 0x01, + }" + # Enable I2C2 for trackpad, touchscreen, pen at 400kHz register "i2c[2]" = "{ .speed = I2C_SPEED_FAST,
9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46537 )
Change subject: mb/google/zork: update USB 2.0 controller Lane Parameter for morphius ......................................................................
Patch Set 7:
Automatic boot test returned (PASS/FAIL/TOTAL): 5/1/6 "HP Compaq 8200 Elite SFF PC" (x86_32) using payload TianoCore : SUCCESS : https://lava.9esec.io/r/24023 "HP Compaq 8200 Elite SFF PC" (x86_32) using payload SeaBIOS : FAIL : https://lava.9esec.io/r/24022 "QEMU x86 q35/ich9" (x86_32) using payload TianoCore : SUCCESS : https://lava.9esec.io/r/24021 "QEMU x86 q35/ich9" (x86_32) using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/24020 "QEMU x86 i440fx/piix4" (x86_32) using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/24018 "QEMU AArch64" using payload LinuxBoot_u-root_kexec : SUCCESS : https://lava.9esec.io/r/24017
Please note: This test is under development and might not be accurate at all!