Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46537 )
Change subject: mb/google/zork: update USB 2.0 controller Lane Parameter for morphius
......................................................................
Patch Set 1:
(3 comments)
https://review.coreboot.org/c/coreboot/+/46537/1//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/46537/1//COMMIT_MSG@9
PS1, Line 9: Enhance USB 2.0 HS DC Voltage Level
What are the default values, and where did you get the new values from?
https://review.coreboot.org/c/coreboot/+/46537/1//COMMIT_MSG@13
PS1, Line 13: TEST=emerge-zork coreboot
Tested how?
https://review.coreboot.org/c/coreboot/+/46537/1/src/mainboard/google/zork/v...
File src/mainboard/google/zork/variants/morphius/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/46537/1/src/mainboard/google/zork/v...
PS1, Line 38: #USB 2.0 strength
Please add a space after the #.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46537
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I278cc0aaddbc9fce595bf57ca69ee8abfc9f5659
Gerrit-Change-Number: 46537
Gerrit-PatchSet: 1
Gerrit-Owner: Kevin Chiu
Kevin.Chiu@quantatw.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Bhanu Prakash Maiya
bhanumaiya@google.com
Gerrit-Reviewer: Eric Peers
epeers@google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Keith Tzeng
keith.tzeng@quanta.corp-partner.google.com
Gerrit-Reviewer: Kevin Chiu
Kevin.Chiu@quantatw.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Rob Barnes
robbarnes@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 19 Oct 2020 14:59:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment