Attention is currently required from: Julius Werner, Yu-Ping Wu. Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51620 )
Change subject: soc/mediatek: Use MRC cache API for asurada ......................................................................
Patch Set 5:
(1 comment)
File src/soc/mediatek/common/include/soc/dramc_param.h:
https://review.coreboot.org/c/coreboot/+/51620/comment/9efd949c_8ef943ec PS4, Line 60: u16 version; /* DRAMC_PARAM_HEADER_VERSION, update in the coreboot */
if no version info was passed to blob? […]
Seems like the "blob" has different meanings - here I meant the "program". Yes MRC driver handled the version, but when passing the data into the external calibration program (dram_run_full_calibration), the version is no longer there.
Consider the case for versions:
coreboot (v4) - MRC_CACHE (v4) - full-k program (v4) # works properly coreboot (v4) - MRC_CACHE (v3) - full-k program (v4) # this should trigger re-train coreboot (V4) - MRC_CACHE (v3) - full-k program (v3) # this would never work for fast-k. we should not release such firmware, but there must be a way to identify such error without reboot loops.