HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33335
Change subject: mb/google/snappy: Remove unneeded 'else' ......................................................................
mb/google/snappy: Remove unneeded 'else'
'else' is not needed after a 'break' or 'return'.
Change-Id: I7b6c319a58b9f4f47de19336d18d00b73d3d3772 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/google/reef/variants/snappy/mainboard.c 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/35/33335/1
diff --git a/src/mainboard/google/reef/variants/snappy/mainboard.c b/src/mainboard/google/reef/variants/snappy/mainboard.c index 950a029..b34b8e2c 100644 --- a/src/mainboard/google/reef/variants/snappy/mainboard.c +++ b/src/mainboard/google/reef/variants/snappy/mainboard.c @@ -70,8 +70,8 @@ if ((ch < '0') || (ch > '9')) { vpd_sku_num = -1; break; - } else - vpd_sku_num = vpd_sku_num * 10 + (ch - '0'); + } + vpd_sku_num = vpd_sku_num * 10 + (ch - '0'); }
if (vpd_sku_num != -1)
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33335 )
Change subject: mb/google/snappy: Remove unneeded 'else' ......................................................................
Patch Set 1: Code-Review+2
Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/33335 )
Change subject: mb/google/snappy: Remove unneeded 'else' ......................................................................
mb/google/snappy: Remove unneeded 'else'
'else' is not needed after a 'break' or 'return'.
Change-Id: I7b6c319a58b9f4f47de19336d18d00b73d3d3772 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/33335 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Vlado Cibic Reviewed-by: Angel Pons th3fanbus@gmail.com --- M src/mainboard/google/reef/variants/snappy/mainboard.c 1 file changed, 2 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved Vlado Cibic: Looks good to me, but someone else must approve
diff --git a/src/mainboard/google/reef/variants/snappy/mainboard.c b/src/mainboard/google/reef/variants/snappy/mainboard.c index 950a029..b34b8e2c 100644 --- a/src/mainboard/google/reef/variants/snappy/mainboard.c +++ b/src/mainboard/google/reef/variants/snappy/mainboard.c @@ -70,8 +70,8 @@ if ((ch < '0') || (ch > '9')) { vpd_sku_num = -1; break; - } else - vpd_sku_num = vpd_sku_num * 10 + (ch - '0'); + } + vpd_sku_num = vpd_sku_num * 10 + (ch - '0'); }
if (vpd_sku_num != -1)
-
Angel Pons (Code Review) -
HAOUAS Elyes (Code Review)
-
Patrick Georgi (Code Review)