Attention is currently required from: Ravi kumar, Shelley Chen, mturney mturney, Julius Werner. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59195 )
Change subject: WIP soc: Added dram information to cbmem WIP ......................................................................
Patch Set 2:
(80 comments)
File src/soc/qualcomm/common/qclib.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133282): https://review.coreboot.org/c/coreboot/+/59195/comment/8591cfda_7531ddf2 PS2, Line 27: #if TEST_CODE /* Added this structure for testing purpose, will be remove once changes are reviewd */ line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133282): https://review.coreboot.org/c/coreboot/+/59195/comment/4fd0c171_75b2a8aa PS2, Line 30: { open brace '{' following struct go on the same line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133282): https://review.coreboot.org/c/coreboot/+/59195/comment/17acf1f3_bbde8d5f PS2, Line 31: uint64_t type; // enum that differentiates DDR3, LPDDR3, LPDDR4, etc. please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133282): https://review.coreboot.org/c/coreboot/+/59195/comment/2bb5f632_81afb5c7 PS2, Line 32: uint64_t num_channels; // To know how may channels are available. please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133282): https://review.coreboot.org/c/coreboot/+/59195/comment/287e44d1_bbfea43e PS2, Line 33: uint64_t reserved[6]; // Reserved [6] please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133282): https://review.coreboot.org/c/coreboot/+/59195/comment/80f5d1b0_94092727 PS2, Line 34: struct please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133282): https://review.coreboot.org/c/coreboot/+/59195/comment/db40eddb_e5571a3e PS2, Line 35: { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133282): https://review.coreboot.org/c/coreboot/+/59195/comment/40cb2cbc_07a85489 PS2, Line 35: { open brace '{' following struct go on the same line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133282): https://review.coreboot.org/c/coreboot/+/59195/comment/83676043_19eff9ea PS2, Line 36: uint64_t density; // Total density Seen on channel code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133282): https://review.coreboot.org/c/coreboot/+/59195/comment/856c0e05_511e4a93 PS2, Line 36: uint64_t density; // Total density Seen on channel please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133282): https://review.coreboot.org/c/coreboot/+/59195/comment/e0cef13a_4731d107 PS2, Line 37: uint64_t io_width; // JEDEC MR8 - io width code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133282): https://review.coreboot.org/c/coreboot/+/59195/comment/1c257380_2180a3cd PS2, Line 37: uint64_t io_width; // JEDEC MR8 - io width please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133282): https://review.coreboot.org/c/coreboot/+/59195/comment/f65ae283_04a6033a PS2, Line 38: uint64_t manufacturer_id; // JEDEC MR5 code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133282): https://review.coreboot.org/c/coreboot/+/59195/comment/647567a3_7d54e0ae PS2, Line 38: uint64_t manufacturer_id; // JEDEC MR5 please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133282): https://review.coreboot.org/c/coreboot/+/59195/comment/2868e474_6cd4b44b PS2, Line 39: uint64_t revision_id[2]; // JEDEC MR6, MR7 code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133282): https://review.coreboot.org/c/coreboot/+/59195/comment/c8eea3db_cf42b4cc PS2, Line 39: uint64_t revision_id[2]; // JEDEC MR6, MR7 please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133282): https://review.coreboot.org/c/coreboot/+/59195/comment/31c8bc0b_2928a820 PS2, Line 40: uint64_t reserved[4]; // Reserved code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133282): https://review.coreboot.org/c/coreboot/+/59195/comment/0843faf7_ad7ffb7c PS2, Line 40: uint64_t reserved[4]; // Reserved please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133282): https://review.coreboot.org/c/coreboot/+/59195/comment/a5581404_f01a5da3 PS2, Line 41: uint64_t serial_id[8]; // for potential future LPDDR5 expansion code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133282): https://review.coreboot.org/c/coreboot/+/59195/comment/027a98c6_1fbc16c4 PS2, Line 41: uint64_t serial_id[8]; // for potential future LPDDR5 expansion please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133282): https://review.coreboot.org/c/coreboot/+/59195/comment/5773efde_cdadba0f PS2, Line 42: } channels[DDR_MAX_NUM_CH_TEST]; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133282): https://review.coreboot.org/c/coreboot/+/59195/comment/7183f135_acde82f8 PS2, Line 43: }dram_info; space required after that close brace '}'
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133282): https://review.coreboot.org/c/coreboot/+/59195/comment/f09edbb6_ca4dc683 PS2, Line 48: /* Save MEM CHIP info in SRAM region to share with ramstage */ code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133282): https://review.coreboot.org/c/coreboot/+/59195/comment/cad80945_4087ca6f PS2, Line 49: mem_chip_offset = (void *)te->blob_address; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133282): https://review.coreboot.org/c/coreboot/+/59195/comment/7d23799e_b5cf85ba PS2, Line 49: mem_chip_offset = (void *)te->blob_address; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133282): https://review.coreboot.org/c/coreboot/+/59195/comment/bd8acddc_129725b4 PS2, Line 50: mem_chip_size = te->size; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133282): https://review.coreboot.org/c/coreboot/+/59195/comment/1529f6d6_d1faee7a PS2, Line 50: mem_chip_size = te->size; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133282): https://review.coreboot.org/c/coreboot/+/59195/comment/89a480b5_f00b4add PS2, Line 55: printk(BIOS_INFO, "%s:%s: Test Code to print memchip information before adding cbmem_add\n", __FILE__, __func__); line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133282): https://review.coreboot.org/c/coreboot/+/59195/comment/3e39b222_8c249c80 PS2, Line 56: memcpy(&memchip, (struct dram_info *)te->blob_address, sizeof(memchip)); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133282): https://review.coreboot.org/c/coreboot/+/59195/comment/1ff5960f_0c126559 PS2, Line 56: memcpy(&memchip, (struct dram_info *)te->blob_address, sizeof(memchip)); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133282): https://review.coreboot.org/c/coreboot/+/59195/comment/a7c3bf11_4132a91e PS2, Line 57: printk(BIOS_INFO, "COREBOOT: MEM CHIP region offset: %p, size: %d\n", (void *)te->blob_address, (int)mem_chip_size); line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133282): https://review.coreboot.org/c/coreboot/+/59195/comment/a234594e_f1596b4d PS2, Line 57: printk(BIOS_INFO, "COREBOOT: MEM CHIP region offset: %p, size: %d\n", (void *)te->blob_address, (int)mem_chip_size); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133282): https://review.coreboot.org/c/coreboot/+/59195/comment/490eec6f_eba3db61 PS2, Line 57: printk(BIOS_INFO, "COREBOOT: MEM CHIP region offset: %p, size: %d\n", (void *)te->blob_address, (int)mem_chip_size); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133282): https://review.coreboot.org/c/coreboot/+/59195/comment/d8ef73bb_77d71124 PS2, Line 58: printk(BIOS_INFO, "COREBOOT: %s : %s : line:%d MEM CHIP : manufacturee_id : %lld \n", __FILE__, __func__, __LINE__, memchip.channels[0].manufacturer_id); line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133282): https://review.coreboot.org/c/coreboot/+/59195/comment/8445ffc5_53667ccc PS2, Line 58: printk(BIOS_INFO, "COREBOOT: %s : %s : line:%d MEM CHIP : manufacturee_id : %lld \n", __FILE__, __func__, __LINE__, memchip.channels[0].manufacturer_id); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133282): https://review.coreboot.org/c/coreboot/+/59195/comment/785a14e0_51a80f5c PS2, Line 58: printk(BIOS_INFO, "COREBOOT: %s : %s : line:%d MEM CHIP : manufacturee_id : %lld \n", __FILE__, __func__, __LINE__, memchip.channels[0].manufacturer_id); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133282): https://review.coreboot.org/c/coreboot/+/59195/comment/0304b850_9fde2967 PS2, Line 58: printk(BIOS_INFO, "COREBOOT: %s : %s : line:%d MEM CHIP : manufacturee_id : %lld \n", __FILE__, __func__, __LINE__, memchip.channels[0].manufacturer_id); unnecessary whitespace before a quoted newline
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133282): https://review.coreboot.org/c/coreboot/+/59195/comment/deff6822_be2ea76a PS2, Line 59: printk(BIOS_INFO, "COREBOOT: %s : %s : MEM CHIP : density : %lld \n", __FILE__, __func__, memchip.channels[0].io_width); line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133282): https://review.coreboot.org/c/coreboot/+/59195/comment/44f88495_042549e9 PS2, Line 59: printk(BIOS_INFO, "COREBOOT: %s : %s : MEM CHIP : density : %lld \n", __FILE__, __func__, memchip.channels[0].io_width); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133282): https://review.coreboot.org/c/coreboot/+/59195/comment/c6c05b1a_24ae9382 PS2, Line 59: printk(BIOS_INFO, "COREBOOT: %s : %s : MEM CHIP : density : %lld \n", __FILE__, __func__, memchip.channels[0].io_width); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133282): https://review.coreboot.org/c/coreboot/+/59195/comment/df951351_acaaa2a4 PS2, Line 59: printk(BIOS_INFO, "COREBOOT: %s : %s : MEM CHIP : density : %lld \n", __FILE__, __func__, memchip.channels[0].io_width); unnecessary whitespace before a quoted newline
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133282): https://review.coreboot.org/c/coreboot/+/59195/comment/47a106ca_a4c800ec PS2, Line 60: printk(BIOS_INFO, "COREBOOT: %s : %s : MEM CHIP : io-width : %lld \n", __FILE__, __func__, memchip.channels[0].density); line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133282): https://review.coreboot.org/c/coreboot/+/59195/comment/bf58f44b_cb1be2ed PS2, Line 60: printk(BIOS_INFO, "COREBOOT: %s : %s : MEM CHIP : io-width : %lld \n", __FILE__, __func__, memchip.channels[0].density); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133282): https://review.coreboot.org/c/coreboot/+/59195/comment/881a8aea_4d7d668b PS2, Line 60: printk(BIOS_INFO, "COREBOOT: %s : %s : MEM CHIP : io-width : %lld \n", __FILE__, __func__, memchip.channels[0].density); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133282): https://review.coreboot.org/c/coreboot/+/59195/comment/9c35acae_183021e1 PS2, Line 60: printk(BIOS_INFO, "COREBOOT: %s : %s : MEM CHIP : io-width : %lld \n", __FILE__, __func__, memchip.channels[0].density); unnecessary whitespace before a quoted newline
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133282): https://review.coreboot.org/c/coreboot/+/59195/comment/ab24ae3a_396e3822 PS2, Line 66: void *mem_region_base; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133282): https://review.coreboot.org/c/coreboot/+/59195/comment/3acfd9c2_32a3361b PS2, Line 66: void *mem_region_base; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133282): https://review.coreboot.org/c/coreboot/+/59195/comment/a424534d_afcffcaa PS2, Line 69: mem_region_base = cbmem_add(CBMEM_ID_MEM_CHIP_INFO, mem_chip_size); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133282): https://review.coreboot.org/c/coreboot/+/59195/comment/c11cc514_3e5bcf2a PS2, Line 69: mem_region_base = cbmem_add(CBMEM_ID_MEM_CHIP_INFO, mem_chip_size); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133282): https://review.coreboot.org/c/coreboot/+/59195/comment/28771d8b_53a36993 PS2, Line 70: ASSERT(mem_region_base != NULL); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133282): https://review.coreboot.org/c/coreboot/+/59195/comment/90af379e_556c71b5 PS2, Line 70: ASSERT(mem_region_base != NULL); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133282): https://review.coreboot.org/c/coreboot/+/59195/comment/b40c5fe7_772a81b0 PS2, Line 72: /* Migrate the data into CBMEM */ code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133282): https://review.coreboot.org/c/coreboot/+/59195/comment/c6ac043c_8b3cb947 PS2, Line 73: memcpy(mem_region_base, mem_chip_offset, mem_chip_size); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133282): https://review.coreboot.org/c/coreboot/+/59195/comment/811e4837_ecb2c324 PS2, Line 73: memcpy(mem_region_base, mem_chip_offset, mem_chip_size); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133282): https://review.coreboot.org/c/coreboot/+/59195/comment/18459180_f70966fd PS2, Line 77: /* Test Code to print memchip information after adding cbmem_addd */ 'addd' may be misspelled - perhaps 'add'?
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133282): https://review.coreboot.org/c/coreboot/+/59195/comment/c978cb73_96bf2a0b PS2, Line 78: printk(BIOS_INFO, "%s:%s: Test Code to print memchip information after adding cbmem_add\n", __FILE__, __func__); line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133282): https://review.coreboot.org/c/coreboot/+/59195/comment/69d2d084_019a146f PS2, Line 80: printk(BIOS_INFO, "COREBOOT: MEM CHIP region offset: %p, size: %d\n", (void *)mem_region_base , (int)mem_chip_size); line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133282): https://review.coreboot.org/c/coreboot/+/59195/comment/1b296d14_1c598fde PS2, Line 80: printk(BIOS_INFO, "COREBOOT: MEM CHIP region offset: %p, size: %d\n", (void *)mem_region_base , (int)mem_chip_size); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133282): https://review.coreboot.org/c/coreboot/+/59195/comment/7d440376_ac396a97 PS2, Line 80: printk(BIOS_INFO, "COREBOOT: MEM CHIP region offset: %p, size: %d\n", (void *)mem_region_base , (int)mem_chip_size); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133282): https://review.coreboot.org/c/coreboot/+/59195/comment/e247d27c_38e681da PS2, Line 80: printk(BIOS_INFO, "COREBOOT: MEM CHIP region offset: %p, size: %d\n", (void *)mem_region_base , (int)mem_chip_size); space prohibited before that ',' (ctx:WxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133282): https://review.coreboot.org/c/coreboot/+/59195/comment/a9dc4184_a04ba6ea PS2, Line 81: printk(BIOS_INFO, "COREBOOT: %s : %s : line:%d MEM CHIP : manufacturee_id : %lld \n", __FILE__, __func__, __LINE__, memchip.channels[0].manufacturer_id); line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133282): https://review.coreboot.org/c/coreboot/+/59195/comment/6ac9f11c_b47680ef PS2, Line 81: printk(BIOS_INFO, "COREBOOT: %s : %s : line:%d MEM CHIP : manufacturee_id : %lld \n", __FILE__, __func__, __LINE__, memchip.channels[0].manufacturer_id); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133282): https://review.coreboot.org/c/coreboot/+/59195/comment/aab98c14_df7bb38a PS2, Line 81: printk(BIOS_INFO, "COREBOOT: %s : %s : line:%d MEM CHIP : manufacturee_id : %lld \n", __FILE__, __func__, __LINE__, memchip.channels[0].manufacturer_id); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133282): https://review.coreboot.org/c/coreboot/+/59195/comment/c39805c5_8ecaaf5b PS2, Line 81: printk(BIOS_INFO, "COREBOOT: %s : %s : line:%d MEM CHIP : manufacturee_id : %lld \n", __FILE__, __func__, __LINE__, memchip.channels[0].manufacturer_id); unnecessary whitespace before a quoted newline
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133282): https://review.coreboot.org/c/coreboot/+/59195/comment/2a7302ae_64d78f3e PS2, Line 82: printk(BIOS_INFO, "COREBOOT: %s : %s : MEM CHIP : density : %lld \n", __FILE__, __func__, memchip.channels[0].io_width); line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133282): https://review.coreboot.org/c/coreboot/+/59195/comment/418445c2_bd4e3675 PS2, Line 82: printk(BIOS_INFO, "COREBOOT: %s : %s : MEM CHIP : density : %lld \n", __FILE__, __func__, memchip.channels[0].io_width); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133282): https://review.coreboot.org/c/coreboot/+/59195/comment/ac352b09_db354290 PS2, Line 82: printk(BIOS_INFO, "COREBOOT: %s : %s : MEM CHIP : density : %lld \n", __FILE__, __func__, memchip.channels[0].io_width); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133282): https://review.coreboot.org/c/coreboot/+/59195/comment/95f88d59_698c7a0b PS2, Line 82: printk(BIOS_INFO, "COREBOOT: %s : %s : MEM CHIP : density : %lld \n", __FILE__, __func__, memchip.channels[0].io_width); unnecessary whitespace before a quoted newline
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133282): https://review.coreboot.org/c/coreboot/+/59195/comment/77124c7c_0303c69d PS2, Line 83: printk(BIOS_INFO, "COREBOOT: %s : %s : MEM CHIP : io-width : %lld \n", __FILE__, __func__, memchip.channels[0].density); line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133282): https://review.coreboot.org/c/coreboot/+/59195/comment/f787a8a7_dea8c58a PS2, Line 83: printk(BIOS_INFO, "COREBOOT: %s : %s : MEM CHIP : io-width : %lld \n", __FILE__, __func__, memchip.channels[0].density); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133282): https://review.coreboot.org/c/coreboot/+/59195/comment/69826f81_2cf017bf PS2, Line 83: printk(BIOS_INFO, "COREBOOT: %s : %s : MEM CHIP : io-width : %lld \n", __FILE__, __func__, memchip.channels[0].density); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133282): https://review.coreboot.org/c/coreboot/+/59195/comment/0cc9af16_9c9b277c PS2, Line 83: printk(BIOS_INFO, "COREBOOT: %s : %s : MEM CHIP : io-width : %lld \n", __FILE__, __func__, memchip.channels[0].density); unnecessary whitespace before a quoted newline
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133282): https://review.coreboot.org/c/coreboot/+/59195/comment/4aea9239_54a42745 PS2, Line 157: sizeof(te->name))) { code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133282): https://review.coreboot.org/c/coreboot/+/59195/comment/2b558f78_72d5a06b PS2, Line 157: sizeof(te->name))) { please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133282): https://review.coreboot.org/c/coreboot/+/59195/comment/c8be6157_06e85bc0 PS2, Line 158: write_mem_chip_information(te); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133282): https://review.coreboot.org/c/coreboot/+/59195/comment/55c45b62_3ba88377 PS2, Line 158: write_mem_chip_information(te); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133282): https://review.coreboot.org/c/coreboot/+/59195/comment/9669dec2_fb23047d PS2, Line 213: qclib_add_if_table_entry(QCLIB_TE_MEM_CHIP_INFO, code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133282): https://review.coreboot.org/c/coreboot/+/59195/comment/f364a41d_aa9f5dfc PS2, Line 213: qclib_add_if_table_entry(QCLIB_TE_MEM_CHIP_INFO, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133282): https://review.coreboot.org/c/coreboot/+/59195/comment/b0bd7f79_5c8a23be PS2, Line 214: _mem_chip_info, REGION_SIZE(mem_chip_info), 0); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-133282): https://review.coreboot.org/c/coreboot/+/59195/comment/49bac46c_1894c9c8 PS2, Line 214: _mem_chip_info, REGION_SIZE(mem_chip_info), 0); please, no spaces at the start of a line
-
build bot (Jenkins) (Code Review)