Change in em100[master]: write_dfifo: Actually send data to FIFO

[Stefan Reinauer (Code Review)]

Stefan Reinauer has uploaded this change for review. ( https://review.coreboot.org/c/em100/+/37122 )

Change subject: write_dfifo: Actually send data to FIFO
......................................................................

write_dfifo: Actually send data to FIFO

The function is not currently used, so this was never discovered.

Change-Id: If2210938fa31604bc81f5599dce8384ff9936b2a
Signed-off-by: Stefan Reinauer 
---
M spi.c
1 file changed, 2 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/em100 refs/changes/22/37122/1

diff --git a/spi.c b/spi.c
index 1a225a4..cc1d706 100644
--- a/spi.c
+++ b/spi.c
@@ -258,6 +258,8 @@
    			" be > 512\n");
    	return 0;
    }
+	memcpy(data, blk, length);
+
    memset(cmd, 0, 16);
    cmd[0] = 0x52; /* write dFIFO */
    cmd[1] = (length >> 8)  & 0xff;

[Stefan Reinauer (Code Review)]

Hello Furquan Shaikh, build bot (Jenkins), Patrick Georgi,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/em100/+/37122

to look at the new patch set (#2).

Change subject: write_dfifo: Actually send data to FIFO
......................................................................

write_dfifo: Actually send data to FIFO

The function is not currently used, so this was never discovered.

Change-Id: If2210938fa31604bc81f5599dce8384ff9936b2a
Signed-off-by: Stefan Reinauer 
---
M spi.c
1 file changed, 2 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/em100 refs/changes/22/37122/2

[Martin Roth (Code Review)]

Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/em100/+/37122 )

Change subject: write_dfifo: Actually send data to FIFO
......................................................................

Patch Set 4: Code-Review+2

[Stefan Reinauer (Code Review)]

Stefan Reinauer has submitted this change. ( https://review.coreboot.org/c/em100/+/37122 )

Change subject: write_dfifo: Actually send data to FIFO
......................................................................

write_dfifo: Actually send data to FIFO

The function is not currently used, so this was never discovered.

Change-Id: If2210938fa31604bc81f5599dce8384ff9936b2a
Signed-off-by: Stefan Reinauer 
Reviewed-on: https://review.coreboot.org/c/em100/+/37122
Tested-by: build bot (Jenkins) 
Reviewed-by: Martin Roth 
---
M spi.c
1 file changed, 2 insertions(+), 0 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Martin Roth: Looks good to me, approved

diff --git a/spi.c b/spi.c
index 1a225a4..cc1d706 100644
--- a/spi.c
+++ b/spi.c
@@ -258,6 +258,8 @@
    			" be > 512\n");
    	return 0;
    }
+	memcpy(data, blk, length);
+
    memset(cmd, 0, 16);
    cmd[0] = 0x52; /* write dFIFO */
    cmd[1] = (length >> 8)  & 0xff;