Attention is currently required from: Zheng Bao.
Hello Zheng Bao,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/69783
to review the following change.
Change subject: smm: Invalid the smm handler region instead of the whole ......................................................................
smm: Invalid the smm handler region instead of the whole
The S3 data needs to be put to smm cache region. If the whole smm regions are invalid, the header information will be lost and the data saving will fail.
Change-Id: I1cd422f35b3dfa25ae8ed8034f05f8d47350fd6e Signed-off-by: Zheng Bao fishbaozi@gmail.com --- M src/soc/amd/common/block/cpu/smm/smm_relocate.c 1 file changed, 15 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/83/69783/1
diff --git a/src/soc/amd/common/block/cpu/smm/smm_relocate.c b/src/soc/amd/common/block/cpu/smm/smm_relocate.c index 4d33b65..c50cf52 100644 --- a/src/soc/amd/common/block/cpu/smm/smm_relocate.c +++ b/src/soc/amd/common/block/cpu/smm/smm_relocate.c @@ -62,7 +62,7 @@ uintptr_t tseg_base; size_t tseg_size;
- smm_region(&tseg_base, &tseg_size); + smm_subregion(SMM_SUBREGION_HANDLER, &tseg_base, &tseg_size);
msr_t msr; msr.lo = tseg_base;