Change in ...coreboot[master]: util/amdfwtool: Close file descriptor on error

[Jacob Garber (Code Review)]

Jacob Garber has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33961

Change subject: util/amdfwtool: Close file descriptor on error
......................................................................

util/amdfwtool: Close file descriptor on error

Prevents a resource leak.

Change-Id: Id5da2df3e37cba499cd2e9a7c3ede34e4de2ed77
Signed-off-by: Jacob Garber 
Found-by: Coverity CID 1402139
---
M util/amdfwtool/amdfwtool.c
1 file changed, 2 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/61/33961/1

diff --git a/util/amdfwtool/amdfwtool.c b/util/amdfwtool/amdfwtool.c
index 37dbcd0..e8ac0b1 100644
--- a/util/amdfwtool/amdfwtool.c
+++ b/util/amdfwtool/amdfwtool.c
@@ -566,11 +566,13 @@

if (fstat(fd, &fd_stat)) {
    	printf("fstat error: %s\n", strerror(errno));
+		close(fd);
    	return -2;
    }

if (fd_stat.st_size > room) {
    	printf("Error: %s will not fit.  Exiting.\n", src_file);
+		close(fd);
    	return -3;
    }

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33961 )

Change subject: util/amdfwtool: Close file descriptor on error
......................................................................

Patch Set 1: Code-Review+1

Change in coreboot[master]: util/amdfwtool: Close file descriptor on error

[Patrick Georgi (Code Review)]

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33961 )

Change subject: util/amdfwtool: Close file descriptor on error
......................................................................

Patch Set 1: Code-Review+2

Change in coreboot[master]: util/amdfwtool: Close file descriptor on error

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/33961 )

Change subject: util/amdfwtool: Close file descriptor on error
......................................................................

util/amdfwtool: Close file descriptor on error

Prevents a resource leak.

Change-Id: Id5da2df3e37cba499cd2e9a7c3ede34e4de2ed77
Signed-off-by: Jacob Garber 
Found-by: Coverity CID 1402139
Reviewed-on: https://review.coreboot.org/c/coreboot/+/33961
Tested-by: build bot (Jenkins) 
Reviewed-by: Paul Menzel 
Reviewed-by: Patrick Georgi 
---
M util/amdfwtool/amdfwtool.c
1 file changed, 2 insertions(+), 0 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Patrick Georgi: Looks good to me, approved
  Paul Menzel: Looks good to me, but someone else must approve

diff --git a/util/amdfwtool/amdfwtool.c b/util/amdfwtool/amdfwtool.c
index 37dbcd0..e8ac0b1 100644
--- a/util/amdfwtool/amdfwtool.c
+++ b/util/amdfwtool/amdfwtool.c
@@ -566,11 +566,13 @@

if (fstat(fd, &fd_stat)) {
    	printf("fstat error: %s\n", strerror(errno));
+		close(fd);
    	return -2;
    }

if (fd_stat.st_size > room) {
    	printf("Error: %s will not fit.  Exiting.\n", src_file);
+		close(fd);
    	return -3;
    }