[M] Change in coreboot[master]: ACPI: Use common code for MADT LAPIC NMIs - coreboot-gerrit

18 Nov 2022


      Attention is currently required from: Lance Zhao, Jason Glenesk, Raul Rangel, Matt DeVillier, Tim Wawrzynczak, Fred Reitberger.
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69527 )
Change subject: ACPI: Use common code for MADT LAPIC NMIs
......................................................................
Patch Set 3:
(1 comment)
File src/include/acpi/acpi.h:
https://review.coreboot.org/c/coreboot/+/69527/comment/469d480b_d9ec3f90 
PS3, Line 628: #define ACPI_MADT_LX2APIC_NMI_ALL_PROCESSORS	(-1UL)
https://qa.coreboot.org/job/coreboot-gerrit/222675/testReport/junit/board/ch...
Do we need ((u32)(-1UL)) here or what was that about?
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/69527
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iaf714d8c2aabd16c59c3bcebc4a207406fc85ca9
Gerrit-Change-Number: 69527
Gerrit-PatchSet: 3
Gerrit-Owner: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk jason.glenesk@gmail.com
Gerrit-Reviewer: Lance Zhao
Gerrit-Reviewer: Matt DeVillier matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Raul Rangel rrangel@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak inforichland@gmail.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Lance Zhao
Gerrit-Attention: Jason Glenesk jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel rrangel@chromium.org
Gerrit-Attention: Matt DeVillier matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Tim Wawrzynczak inforichland@gmail.com
Gerrit-Attention: Fred Reitberger reitbergerfred@gmail.com
Gerrit-Comment-Date: Fri, 18 Nov 2022 13:17:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment