Elyes Haouas has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/86559?usp=email )
Change subject: libpayload/drivers/usb/uhci: Remove "else" after "return" ......................................................................
libpayload/drivers/usb/uhci: Remove "else" after "return"
"else" is not useful after a "return".
Change-Id: I8950ad576a0252529258978935dc31ba53028b28 Signed-off-by: Elyes Haouas ehaouas@noos.fr --- M payloads/libpayload/drivers/usb/uhci.c 1 file changed, 4 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/59/86559/1
diff --git a/payloads/libpayload/drivers/usb/uhci.c b/payloads/libpayload/drivers/usb/uhci.c index 7590ab3..1c6520f 100644 --- a/payloads/libpayload/drivers/usb/uhci.c +++ b/payloads/libpayload/drivers/usb/uhci.c @@ -429,12 +429,11 @@ virt_to_phys(td) & ~(FLISTP_QH | FLISTP_TERMINATE); td = wait_for_completed_qh(dev->controller, UHCI_INST(dev->controller)->qh_data); - if (td == 0) { + if (td == 0) return 0; - } else { - td_dump(td); - return 1; - } + + td_dump(td); + return 1; }
/* finalize == 1: if data is of packet aligned size, add a zero length packet */