[S] Change in coreboot[master]: soc/intel/meteorlake: Fix PortUsb30Enable configuration - coreboot-gerrit

1 Apr 2023


      Attention is currently required from: Tarun Tuli, Subrata Banik, Ivy Jian.
Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74143 )
Change subject: soc/intel/meteorlake: Fix PortUsb30Enable configuration
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
...
UsbTcPortEn has been checked by is_dev_enabled in fill_fsps_tcss_paramsand. […]
Yes, this is what I mean, we should check USB3/USB2 device tree node to create the bitmap too.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/74143
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic04b9eb236ed28a76ee516c52fc0c983cb8f2c0e
Gerrit-Change-Number: 74143
Gerrit-PatchSet: 2
Gerrit-Owner: Ivy Jian ivy.jian@quanta.corp-partner.google.com
Gerrit-Reviewer: Kapil Porwal kapilporwal@google.com
Gerrit-Reviewer: Subrata Banik subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Eric Lai eric_lai@quanta.corp-partner.google.com
Gerrit-Attention: Tarun Tuli taruntuli@google.com
Gerrit-Attention: Subrata Banik subratabanik@google.com
Gerrit-Attention: Ivy Jian ivy.jian@quanta.corp-partner.google.com
Gerrit-Comment-Date: Sat, 01 Apr 2023 05:51:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik subratabanik@google.com
Comment-In-Reply-To: Ivy Jian ivy.jian@quanta.corp-partner.google.com
Comment-In-Reply-To: Eric Lai eric_lai@quanta.corp-partner.google.com
Gerrit-MessageType: comment