Change in coreboot[master]: soc/intel/broadwell: Convert some CONFIG(CHROMEOS) preprocessor - coreboot-gerrit

3 Feb 2021


      Attention is currently required from: Matt DeVillier, Kyösti Mälkki, Patrick Rudolph.
Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50252 )
Change subject: soc/intel/broadwell: Convert some CONFIG(CHROMEOS) preprocessor
......................................................................
Patch Set 1:
(1 comment)
File src/soc/intel/broadwell/gma.c:
https://review.coreboot.org/c/coreboot/+/50252/comment/db7ce447_a584f2f5 
PS1, Line 518: !CONFIG(CHROMEOS)
might be able to just drop this and call display_init_required()?  I think originally these functions were part of chrome os checks but display_init_required() now checks for CONFIG(VBOOT) internally.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/50252
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie3feee0448175db2b6ed4e8e37d92de3af9be371
Gerrit-Change-Number: 50252
Gerrit-PatchSet: 1
Gerrit-Owner: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Reviewer: Matt DeVillier matt.devillier@gmail.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Duncan Laurie dlaurie@chromium.org
Gerrit-Attention: Matt DeVillier matt.devillier@gmail.com
Gerrit-Attention: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Attention: Patrick Rudolph siro@das-labor.org
Gerrit-Comment-Date: Wed, 03 Feb 2021 17:34:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment